Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped Epoch expected functionality #1932

Open
Cmdv opened this issue Jan 20, 2025 · 1 comment
Open

Dropped Epoch expected functionality #1932

Cmdv opened this issue Jan 20, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Cmdv
Copy link
Contributor

Cmdv commented Jan 20, 2025

Original message taken from our discord channel:

Hey DB-Sync team, while checking in on the current governance actions via koios, we discovered an issue with the dropped_epoch entries.

According to the documentation:
If not null, then this proposal has been dropped at the specfied epoch. A proposal is dropped when it's expired or enacted or when one of its dependencies is expired.
the value should be set to a non-null value in case a proposal expired or got enacted.

However, tests on MainNet, SanchoNet and PreView showed, that the value for dropped_epoch is never set and stays at null.

This example was taken from epoch 582:

    "proposed_epoch": 492,
    "ratified_epoch": 493,
    "enacted_epoch": 494,
    "dropped_epoch": null,
    "expired_epoch": null,
    "expiration": 553,

The proposal was enacted and did not expire. So i think there is a bug that should be corrected that according to the documentation also enacted proposals should get an entry in the dropped_epoch value. Thanks to <@667815879488045056> and <@742729268106231941> for helping to double-check.

@Cmdv Cmdv added the bug Something isn't working label Jan 20, 2025
@HeptaSean
Copy link

Maybe related: For expired proposals, e.g., https://adastat.net/governances/51f495aa23f4b3b3aa90afde4a0e67823bb7ac4ac65f5ffbb138373b863f2f7400, the dropped_epoch is expired_epoch + 1:

    "proposed_epoch": 518,
    "ratified_epoch": null,
    "enacted_epoch": null,
    "dropped_epoch": 526,
    "expired_epoch": 525,
    "expiration": 525,

As stated in #1704 (comment) (but not followed up on), I would expect them to match (or at least a documented reason why they do not match).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants