Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched entity rendering causes Powah reactor to become translucent #2615

Open
embeddedt opened this issue Feb 2, 2025 · 0 comments
Open

Comments

@embeddedt
Copy link

What happened?

To reproduce:

  1. On NeoForge (I used 21.1.84), install Iris 1.8.1, Powah 6.1.6, Industrial Foregoing 1.21-3.6.22 (and associated dependencies).
  2. Open the following world: reactor_sorting_issue.zip
  3. Observe that stained glass and the IF working area visual both render through the reactor.

Disabling the working area on the IF machine (can be done on the central right portion of its GUI) makes the reactor correctly occlude geometry behind it.

This issue can be observed without a shader enabled, but not if Iris is completely removed, so I suspect it's an issue with the batched entity rendering optimization.

Screenshots

Image

Log output

No response

Minecraft Version

Minecraft 1.21.1

Iris Version

1.8.1

Operating System

Arch Linux

What is your GPU?

RX 6600

Additional context

The working area and reactor both appear to render as block entities using a typical BlockEntityRenderer that writes into a buffer provided by the MultiBufferSource. The issue seems dependent on the order in which they render, so their placement relative to one another in the chunk section is important.

Powah's BER: https://github.com/Technici4n/Powah/blob/1.21.1/src/main/java/owmii/powah/client/render/tile/ReactorRenderer.java
IF's BER: https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/1.21/src/main/java/com/buuz135/industrial/proxy/client/render/WorkingAreaTESR.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant