Skip to content

Commit b91ed84

Browse files
authored
Merge pull request #37 from ItzNotABug/fix-36-null-url-decoding-crash
Fix #36.
2 parents 3f43079 + e30f24f commit b91ed84

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "ghosler",
33
"description": "Send newsletter emails to your members, using your own email credentials!",
4-
"version": "0.92",
4+
"version": "0.93",
55
"private": true,
66
"main": "app.js",
77
"type": "module",

utils/newsletter.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,8 @@ export default class Newsletter {
213213
renderingData.newsletter.unsubscribeLink,
214214
renderingData.newsletter.feedbackLikeLink,
215215
renderingData.newsletter.feedbackDislikeLink,
216-
// featuredImage can be null, so we should to filter them.
217-
...renderingData.post.latestPosts.filter(post => post.featuredImage).map(post => post.featuredImage)
218-
].forEach(internalLinks => urlsToExclude.push(he.decode(internalLinks)));
216+
...renderingData.post.latestPosts.map(post => post.featuredImage)
217+
].forEach(linkToTrack => linkToTrack && urlsToExclude.push(he.decode(linkToTrack)));
219218

220219
const trackedLinks = new Set();
221220
const $ = cheerio.load(renderedPostData);

0 commit comments

Comments
 (0)