Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send email #25

Open
davidtran opened this issue Nov 26, 2020 · 0 comments
Open

Fix send email #25

davidtran opened this issue Nov 26, 2020 · 0 comments
Assignees

Comments

@davidtran
Copy link
Contributor

export default function generateEmailTemplate({ fileName, data }) {
  const templatePath = `${path.resolve()}/email-template/${fileName}`;
  const template = execSync(`mjml ${templatePath}`).toString();
  return handlebars.compile(template)(data).toString();
}
  • please use mjml npm package to compile email
  • never use NodeJS sync method. It hurts app performance. Use async/await or Promise instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants