From ecfc126581bb9f46a2dff26be7060243211e81b6 Mon Sep 17 00:00:00 2001 From: RealDiligent Date: Sun, 26 Jul 2026 07:59:53 +0800 Subject: [PATCH] fix(orb): correct two false 'private to this file' location comments review-evasion.ts's header claimed ReopenRecloseOutcome is private to the file, but it's exported and consumed by processors.ts; and linked-issue-label-propagation-fetch.ts misattributed hasMaintainerOrOwnerPermission to processors.ts when it lives in review-evasion.ts. Both comments corrected; no behavioral change. Co-Authored-By: Claude Opus 4.8 --- src/queue/review-evasion.ts | 8 +++++--- src/review/linked-issue-label-propagation-fetch.ts | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/queue/review-evasion.ts b/src/queue/review-evasion.ts index c2a33cd401..7d9017413f 100644 --- a/src/queue/review-evasion.ts +++ b/src/queue/review-evasion.ts @@ -2,9 +2,11 @@ // the file's own module-split sequence, after transient-locks.ts, signal-snapshot.ts, // duplicate-detection.ts, and slop-detection.ts). Only the top-level "maybe*" entry points are // exported (each called from exactly one webhook-handler call site still in processors.ts) -- every other -// function/type/constant here (withPrActuationLock, evaluateCloseEnforcementGate, hasMaintainerOrOwnerPermission, -// the "close*If*" implementations, ReopenRecloseOutcome, REVIEW_EVASION_CLOSED_EVENT_TYPE) is private to this -// file, since none of them had any caller outside this cluster in the original file either. +// function/constant here (withPrActuationLock, evaluateCloseEnforcementGate, hasMaintainerOrOwnerPermission, +// the "close*If*" implementations, REVIEW_EVASION_CLOSED_EVENT_TYPE) is private to this file, since none of +// them had any caller outside this cluster in the original file either. The one exception is the exported +// `ReopenRecloseOutcome` type, which processors.ts imports and consumes -- reshaping it needs a cross-file +// impact check there. // maybeCloseSynchronizeAmendment (#synchronize-close-policy) is a later, 6th addition alongside the original // 5 extracted here -- same shape and reasoning as its siblings, added directly to this module rather than // growing processors.ts again. diff --git a/src/review/linked-issue-label-propagation-fetch.ts b/src/review/linked-issue-label-propagation-fetch.ts index 272899ddd0..70551cee31 100644 --- a/src/review/linked-issue-label-propagation-fetch.ts +++ b/src/review/linked-issue-label-propagation-fetch.ts @@ -41,7 +41,7 @@ type MaintainerCheckResult = "maintainer" | "not_maintainer" | "inconclusive"; /** Whether `login` holds a maintainer-equivalent permission on `repoFullName` -- the literal repo owner, * a fleet-operator in the global `ADMIN_GITHUB_LOGINS` allowlist, or a live GitHub collaborator with * admin/maintain/write access (#priority-linked-issue-gate-ownership). Mirrors - * `hasMaintainerOrOwnerPermission` in `src/queue/processors.ts` (kept as its own copy here rather than + * `hasMaintainerOrOwnerPermission` in `src/queue/review-evasion.ts` (kept as its own copy here rather than * imported, since that one is private to a file this module's header comment explicitly must NOT pull * into its import graph -- see the file-level comment above). A CONFIRMED answer (including a 404, * `getRepositoryCollaboratorPermission`'s real "not a collaborator" signal) resolves deterministically;