From 929f510b0b9c2d7877e9e6276885cdda09ce8586 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 31 Mar 2025 22:45:12 +0200 Subject: [PATCH 1/4] Disablew non-working tets (with issue links) --- .../java/org/jabref/logic/importer/fetcher/ApsFetcherTest.java | 2 ++ .../logic/importer/fetcher/AstrophysicsDataSystemTest.java | 2 ++ .../jabref/logic/importer/fetcher/BiodiversityLibraryTest.java | 2 ++ .../jabref/logic/importer/fileformat/ACMPortalParserTest.java | 2 ++ 4 files changed, 8 insertions(+) diff --git a/src/test/java/org/jabref/logic/importer/fetcher/ApsFetcherTest.java b/src/test/java/org/jabref/logic/importer/fetcher/ApsFetcherTest.java index 33d48b36583..78d4832f975 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/ApsFetcherTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/ApsFetcherTest.java @@ -8,11 +8,13 @@ import org.jabref.testutils.category.FetcherTest; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @FetcherTest +@Disabled("See https://github.com/JabRef/jabref/issues/12864") class ApsFetcherTest { private ApsFetcher finder; diff --git a/src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java b/src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java index b18f514b68c..a239d00a716 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/AstrophysicsDataSystemTest.java @@ -15,6 +15,7 @@ import org.jabref.testutils.category.FetcherTest; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.mockito.Answers; @@ -25,6 +26,7 @@ import static org.mockito.Mockito.when; @FetcherTest +@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/843") public class AstrophysicsDataSystemTest implements PagedSearchFetcherTest { private AstrophysicsDataSystem fetcher; diff --git a/src/test/java/org/jabref/logic/importer/fetcher/BiodiversityLibraryTest.java b/src/test/java/org/jabref/logic/importer/fetcher/BiodiversityLibraryTest.java index a42d50a8772..219bd3e401a 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/BiodiversityLibraryTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/BiodiversityLibraryTest.java @@ -15,6 +15,7 @@ import kong.unirest.core.json.JSONObject; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ValueSource; @@ -26,6 +27,7 @@ import static org.mockito.Mockito.when; @FetcherTest +@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/844") class BiodiversityLibraryTest { private final String RESPONSE_FORMAT = "&format=json"; diff --git a/src/test/java/org/jabref/logic/importer/fileformat/ACMPortalParserTest.java b/src/test/java/org/jabref/logic/importer/fileformat/ACMPortalParserTest.java index 80dfde0ac8c..df2a6dae718 100644 --- a/src/test/java/org/jabref/logic/importer/fileformat/ACMPortalParserTest.java +++ b/src/test/java/org/jabref/logic/importer/fileformat/ACMPortalParserTest.java @@ -18,12 +18,14 @@ import org.apache.hc.core5.net.URIBuilder; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; @FetcherTest +@Disabled("https://github.com/jabref/jabref/issues/10257") class ACMPortalParserTest { ACMPortalParser parser; From 32353a4653a619d0c0f314ae454603055aec0ecc Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 31 Mar 2025 22:45:22 +0200 Subject: [PATCH 2/4] Reorder asserts --- .../importer/fetcher/SearchBasedFetcherCapabilityTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/jabref/logic/importer/fetcher/SearchBasedFetcherCapabilityTest.java b/src/test/java/org/jabref/logic/importer/fetcher/SearchBasedFetcherCapabilityTest.java index 5de34281403..3c9dccba25a 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/SearchBasedFetcherCapabilityTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/SearchBasedFetcherCapabilityTest.java @@ -80,6 +80,8 @@ default void supportsYearRangeSearch() throws Exception { List yearsInYearRange = List.of("2018", "2019", "2020"); List result = getFetcher().performSearch("year-range:2018-2020"); + assertFalse(result.isEmpty()); + FieldPreferences fieldPreferences = mock(FieldPreferences.class); when(fieldPreferences.getNonWrappableFields()).thenReturn(FXCollections.observableArrayList()); ImportCleanup.targeting(BibDatabaseMode.BIBTEX, fieldPreferences).doPostCleanup(result); @@ -88,8 +90,8 @@ default void supportsYearRangeSearch() throws Exception { .filter(Optional::isPresent) .map(Optional::get) .distinct() - .collect(Collectors.toList()); - assertFalse(result.isEmpty()); + .toList(); + assertTrue(yearsInYearRange.containsAll(differentYearsInResult)); } From 325e723e9a6e77462311ab6206d5e06451501935 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 31 Mar 2025 22:46:27 +0200 Subject: [PATCH 3/4] Disable non-working test --- .../org/jabref/logic/importer/fetcher/LOBIDFetcherTest.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/java/org/jabref/logic/importer/fetcher/LOBIDFetcherTest.java b/src/test/java/org/jabref/logic/importer/fetcher/LOBIDFetcherTest.java index 9b5de6f84f0..2a136d0834e 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/LOBIDFetcherTest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/LOBIDFetcherTest.java @@ -93,6 +93,12 @@ void searchByEmptyQueryFindsNothing() throws Exception { public void supportsYearSearch() { } + @Test + @Override + @Disabled("Results returned contain a few incorrect years. The majority are accurate") + public void supportsYearRangeSearch() { + } + @Override public PagedSearchBasedFetcher getPagedFetcher() { return fetcher; From 7b3f34599cb69da85e7fe8d0f39e6e0d36d4efdd Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Mon, 31 Mar 2025 22:54:13 +0200 Subject: [PATCH 4/4] Disalbe fetcher tests --- src/test/java/org/jabref/logic/importer/fetcher/IEEETest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/org/jabref/logic/importer/fetcher/IEEETest.java b/src/test/java/org/jabref/logic/importer/fetcher/IEEETest.java index 4d12cac558b..ae89222e70b 100644 --- a/src/test/java/org/jabref/logic/importer/fetcher/IEEETest.java +++ b/src/test/java/org/jabref/logic/importer/fetcher/IEEETest.java @@ -28,6 +28,7 @@ import static org.mockito.Mockito.when; @FetcherTest +@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/846") class IEEETest implements SearchBasedFetcherCapabilityTest, PagedSearchFetcherTest { private static ImportFormatPreferences importFormatPreferences;