-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Better heuristics for the title and the author (#11999) #14235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @alexvsf0!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
|
Thank you for submitting an early draft. I wonder why no JUnit test cases are added. How could you test your code? At least |
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests.
|
Your pull request conflicts with the target branch. Please merge with your code. |
Closes _____
Closes #11999
I wrote a better heuristic for the title and for the authors, which gives for the documents I tried the right title and authors.
The next step is to correct the abstract, because it doesn't understand if there are multiple columns.
Steps to test
After launching jabref, create a new library, import a pdf, and then there will be different options for the title and the authors. The first colmun uses metadata, and the second one uses pdf's content, which is the part I modificated. This second column should correspond to the real title and the real authors of the document.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)