-
Notifications
You must be signed in to change notification settings - Fork 121
Fix build instructions #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@koppor I always use gradlew run |
The section is about building a binary. That "run" appears strange. |
One can use See also https://blog.jabref.org/2025/05/31/run-pr/ The aim of that section is, however, to have an installer (or at least a portable edition) - not just run The new task to call is Proposal:
Section outline:
These steps are adapted from https://blog.jabref.org/2025/05/31/run-pr/ (instead of You can adapt if you find other things more intuitive. For instance, One could do:
One neesd to run the ![]() |
That failed for me because it relies on WiX, which I do not have installed. Should I add it as a prerequiste on Windows? |
Ah yes, wixtoolset is a requirement for jpackage on windows |
After thinking again about your issue and seeing your email, I think this might be what you want https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/ |
Google found https://stackoverflow.com/a/79256849/873282 But
https://github.com/wixtoolset/issues#open-source-maintenance-fee Locally, I have WiX v3.14 running. I think, this version is not covered by that fee.
|
Thank you for the feedback. I have updated the PR to use the I added a Running from source section. Is there any reason to use I have added a JabRef PR: Add WixToolset (and Bash for Windows recommendation) to Windows setup. |
This addresses issue #578. (Fixes #578)
The reason I don't recommend
gradlew run
is that runs all the modules and has to be exited with Ctrl + C.FYI I removed the reference to
jabgui.bat
because that script failed when I ran it in a Windows CMD shell or in PowerShell. I will file an issue in the JabRef repo.