Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some domain frameworks are redundant #309

Open
JackEblan opened this issue Feb 24, 2025 · 3 comments
Open

Some domain frameworks are redundant #309

JackEblan opened this issue Feb 24, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request p1 Refactor Refactor the code. Only available to the Maintainer.

Comments

@JackEblan
Copy link
Owner

JackEblan commented Feb 24, 2025

Some frameworks in the domain are actually not being used in the use cases. We should remove them and put those interfaces in the framework modules instead.

@JackEblan
Copy link
Owner Author

Only put Android Frameworks in the domain especially their interfaces if it's actually crucial or needed in use cases. I've been wrapping my head around before on how to make wrappers from those Android Classes without realizing that they're actually useless in the domain.

@JackEblan JackEblan self-assigned this Feb 24, 2025
@JackEblan JackEblan added the bug Something isn't working label Feb 24, 2025
@JackEblan JackEblan changed the title Domain frameworks is redundant Some domain frameworks are redundant Feb 24, 2025
@JackEblan
Copy link
Owner Author

In that way, feature modules can depend on the :framework:* directly.

@JackEblan
Copy link
Owner Author

JackEblan commented Feb 24, 2025

The best use case example is UpdateUsageStatsForegroundServiceUseCase.kt where it actually use an Android Framework called UsageStatsManager which is only for Android so it should be included in the domain as framework.

@JackEblan JackEblan added enhancement New feature or request Refactor Refactor the code. Only available to the Maintainer. p1 and removed bug Something isn't working labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1 Refactor Refactor the code. Only available to the Maintainer.
Projects
None yet
Development

No branches or pull requests

1 participant