WrongTimberUsageDetector.checkNestedStringFormat NPE

[deM1d]

Hi! We use latest Timber version(4.7.1). I found some issue in custom Lint rule(WrongTimberUsageDetector). Did not go deeper to find reason, why it is crashing. Just post you simple code, that initiates NPE.

Code:
TextUtils.join(",", Arrays.asList(String.format("Hello %s", "World"), "Hello World"));

Crash log:

NullPointerException:
WrongTimberUsageDetector.checkNestedStringFormat(WrongTimberUsageDetector.java:111)?
WrongTimberUsageDetector.visitMethod(WrongTimberUsageDetector.java:74)?
UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1027)?UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1007)?
UCallExpression$DefaultImpls.accept(UCallExpression.kt:99)?
JavaUCallExpression.accept(javaUCallExpressions.kt:24)?
UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:48)?
JavaUCompositeQualifiedExpression.accept(JavaUCompositeQualifiedExpression.kt:22)

Hope, this info will be helpful for you to find solve,

[yogurtearl]

We started getting a similar error with AGP 3.3.0. Didn't happen with AGP 3.2.1

NullPointerException:WrongTimberUsageDetector.checkNestedStringFormat(WrongTimberUsageDetector.java:111)
←WrongTimberUsageDetector.visitMethod(WrongTimberUsageDetector.java:74)
←Detector.visitMethodCall(Detector.kt:518)
←UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1059)
←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1039)
←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:142)
←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:48)
←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:29)

[yogurtearl]

Swapping String.format for Kotlin string template seems to work around this.

[riyaz]

This issue is happening in java too after updating to timber 10 even if timber is not used in the class, only workaround to split the String.format to two lines for me

[vanniktech]

Also getting this with AGP 3.5.0-rc03:

java.lang.NullPointerException
at timber.lint.WrongTimberUsageDetector.checkNestedStringFormat(WrongTimberUsageDetector.java:111)
at timber.lint.WrongTimberUsageDetector.visitMethod(WrongTimberUsageDetector.java:74)
at com.android.tools.lint.detector.api.Detector.visitMethodCall(Detector.kt:535)
at com.android.tools.lint.client.api.UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1081)
at com.android.tools.lint.client.api.UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1061)

Stack: NullPointerException:WrongTimberUsageDetector.checkNestedStringFormat(WrongTimberUsageDetector.java:111)←WrongTimberUsageDetector.visitMethod(WrongTimberUsageDetector.java:74)←Detector.visitMethodCall(Detector.kt:535)←UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1081)←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1061)←UCallExpression$DefaultImpls.accept(UCallExpression.kt:99)←UCallExpressionEx$DefaultImpls.accept(UCallExpression.kt:-1)←JavaUCallExpression.accept(javaUCallExpressions.kt:26)

The relevant code looks like this:

storage.put(String.format(KEY_VALUE_PREFIX, providerId), enabled).subscribe(Functions.EMPTY_ACTION, Timber::w);