used macro doesn't get suggestion

[DailyShana]

as shown in the above screen shot, there is a \aaabbb, and then type \aaa the \aaabbb is not shown in the suggestion list.

before version 9.12.0, the \aaabbb will shown as expected:

[James-Yu]

You need to define it with macros like newcommand before the extension parses it.

If the macros are provided by your document class, there is another config to point to a new command definition file.

[jlelong]

I remember that the extension used to parse latex files for macros appearing in the body of the document. This part is still present in

LaTeX-Workshop/src/completion/completer/macro.ts

Lines 309 to 315 in 707b058

	function parseContent(content: string, filePath: string): CmdEnvSuggestion[] {
	const cmdInPkg: CmdEnvSuggestion[] = []
	const packages = lw.completion.usepackage.getAll('latex-expl3')
	Object.entries(packages).forEach(([packageName, options]) => {
	provideCmdInPkg(packageName, options, cmdInPkg)
	})
	const cmdReg = /\\([a-zA-Z@_]+(?::[a-zA-Z]*)?\*?)({[^{}]*})?({[^{}]*})?({[^{}]*})?/g

but has somehow disappeared from

LaTeX-Workshop/src/completion/completer/macro.ts

Line 217 in 707b058

function parseAst(node: Ast.Node, filePath: string, defined?: Set<string>): CmdEnvSuggestion[] {

I think this is what @DailyShana refers to. Is it an intentional removal or should we work on implementing it back?

[James-Yu]

This is because that unified won’t absorb unknown arguments for arbitrary macro, unless predefined. It make create argument-less suggestions, may not be quite useful. In the fallback logic, the behavior was retained. I’m not sure if such partial support would be a good idea.

[jlelong]

Thanks for the explanation. I will update the wiki https://github.com/James-Yu/LaTeX-Workshop/wiki/Intellisense#commands-starting-with- (second item)

[DailyShana]

This is because that unified won’t absorb unknown arguments for arbitrary macro, unless predefined. It make create argument-less suggestions, may not be quite useful. In the fallback logic, the behavior was retained. I’m not sure if such partial support would be a good idea.

I think suggestions without argument is better than no suggestions. we can explain the reason in the wiki