[codex] Repair transfer flows in bundled templates#6
Draft
cgdusek wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenTransferandAssetOwnertemplatessetupflow, proposal accept/reject/withdraw, and the invariant that owner-only direct transfers fail without recipient authorizationRoot cause
The bundled templates mixed a one-step transfer API with contract creations that required the recipient as a signatory, and the proposal contracts dropped the original stakeholders while also returning consumed contract ids on rejection and withdrawal.
Validation
tokenandassetprojects from this branch in a new temp directorydpm testin both generated projects with DPM 3.4.11 and OpenJDK 17setup,proposalAcceptFlow,proposalRejectRestoresOriginal, andproposalWithdrawRestoresOriginalall pass in both generated projectsdirectTransferWithoutRecipientFailspasses in both generated projects as the negative authorization checkCloses #5.