Code review and refactor

[kubazuch]

Read current code and refactor all weak points.

DDD plan

• code is separated into layers: API (controller), domain (model + service), infra (repository)
• layers communicate like: Controller -> Service -> Repository and ONLY like that.
• Service can use other Services, Repository can use other Repositories, Service can use only one Repository!
• If endpoint has a PUT edit endpoint, it should ideally also have a PATCH edit endpoint, where PUT takes whole object, and PATCH just some of the object fields.

API layer

• input data validation, conversion, etc. should be handled in Controller
• Controller can call Service, controller also uses Dtos and Mappers
• Controller is the only place in the app that knows about users as in their credentials and authorities
• Use Authentication authentication as parameter and authentication.getPrincipal() to get logged in User
• Use @...Mapping(params = ...) to separate logic depending on parameter

Domain layer

• Services return Model objects, there are no Dtos in any Service
• Exceptions are thrown in Services
• Thrown exceptions are semantic!

Infrastructure layer

• All SQL calls are prepared to do things in the DBMS
• No tolerance for situations such as getting huge amounts of data from database just to filter it in backend

Smaller tasks, divided by domain

• Auth domain is refactored #117
• Brand domain is refactored #118
• Category domain is refactored #119
• Ingredient domain is refactored #120
• Product domain is refactored #121
• Provider domain is refactored #122
• Review domain is refactored #123
• User domain is refactored #124

[migoox]

Looks great, I would suggest to either use exactly one repository or to use other services in a service.

It should nicely layer our app: Repository -> Repository manager service -> Service -> Controller

On the other hand it may be overkill for our app, let me know what do you think

[mslup]

Delete review endpoint shouldn't be managed by the product controller. Deleting should be done with the reviewId, user can delete only their review, moderator can delete any review.

PUT requests should be changed to PATCH requests.

[kubazuch]

PUT requests should be changed to PATCH requests.

Not all. Some of the request can still be PUT but I want to have both PUT and PATCH for most of the endpoints

[kubazuch]

Delete review endpoint shouldn't be managed by the product controller. Deleting should be done with the reviewId, user can delete only their review, moderator can delete any review.

I think that the placement of all endpoints needs to be reconsidered. We will discuss that during next meeting.