Skip to content

update to 2.x of oauth gem as dependency? #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jrochkind opened this issue Oct 12, 2022 · 3 comments · May be fixed by #97
Open

update to 2.x of oauth gem as dependency? #96

jrochkind opened this issue Oct 12, 2022 · 3 comments · May be fixed by #97

Comments

@jrochkind
Copy link

jrochkind commented Oct 12, 2022 •
edited
Loading

dropbox_api requires oauth1 gem 1.x

dropbox_api/dropbox_api.gemspec

Line 24 in 11bd1cf

spec.add_dependency 'oauth2', '~> 1.1'

However, oauth gem now has a 2.0 release as of June 2022. https://rubygems.org/gems/oauth2/versions/2.0.0

Instalilng the last oauth2 1.x release produces this warning:

You have installed oauth2 version 1.4.11, which is EOL.
No further support is anticipated for the 1.4.x series.

OAuth2 version 2 is released.
There are BREAKING changes, but most will not encounter them, and upgrading should be easy!

We have made two other major migrations:
1. master branch renamed to main
2. Github has been replaced with Gitlab

Please see:
• https://gitlab.com/oauth-xx/oauth2#what-is-new-for-v20
• https://gitlab.com/oauth-xx/oauth2/-/blob/main/CHANGELOG.md
• https://groups.google.com/g/oauth-ruby/c/QA_dtrXWXaE

Please upgrade, report issues, and support the project! Thanks, |7eter l-|. l3oling

Could dropbox_api be updated to allow use of oath2 2.x, perhaps allowing both 1.x and 2.x?
@jrochkind
Copy link
Author

jrochkind commented Dec 19, 2022 •
edited
Loading

hi! i'm curious if anyone is currently around maintaining this gem!

I could try a PR as above, would anyone be here to review/merge it?

@jrochkind jrochkind linked a pull request Dec 19, 2022 that will close this issue
Open
@Laykou
Copy link

Laykou commented Jan 17, 2023

@Jesus Are you still in charge of this gem, please? We would also really benefit of updating the oauth2 dependency

@rainerborene
Copy link

rainerborene commented Aug 19, 2023 •
edited
Loading

@Jesus I can maintain this gem if you're not interested anymore. Need help with this issue as well.

@jrochkind jrochkind mentioned this issue Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow version 2.x of oauth dependency jrochkind/dropbox_api
3 participants
@rainerborene @jrochkind @Laykou