From be9f8a3175a315f8a2011c7d87855ea84a257c84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Manzano?= Date: Wed, 4 Oct 2017 08:03:46 +0200 Subject: [PATCH 1/2] Update project using latest versions of plugins/libraries. --- build.gradle | 15 +++-- gradle/wrapper/gradle-wrapper.properties | 4 +- kfingerprintmanager/build.gradle | 2 +- ...FingerprintAuthenticationDialogFragment.kt | 55 ++++++++----------- .../base/ui/FingerprintBaseDialogFragment.kt | 5 +- .../ui/FingerprintEncryptionDialogFragment.kt | 10 ++-- .../kfingerprintmanager/utils/ViewUtils.kt | 2 +- sample/build.gradle | 2 +- .../fingerprintmanager/sample/MainActivity.kt | 4 +- 9 files changed, 43 insertions(+), 56 deletions(-) diff --git a/build.gradle b/build.gradle index 8ab0f6c..3dc4e32 100644 --- a/build.gradle +++ b/build.gradle @@ -4,12 +4,10 @@ buildscript { ext.kotlin_version = '1.1.2-3' repositories { jcenter() - maven { - url 'https://maven.google.com' - } + google() } dependencies { - classpath 'com.android.tools.build:gradle:2.3.2' + classpath 'com.android.tools.build:gradle:2.3.3' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" // NOTE: Do not place your application dependencies here; they belong @@ -20,16 +18,17 @@ buildscript { allprojects { repositories { jcenter() + google() } } ext { minSdkVersion = 23 - targetSdkVersion = 25 - compileSdkVersion = 25 - buildToolsVersion = '25.0.3' + targetSdkVersion = 26 + compileSdkVersion = 26 + buildToolsVersion = '26.0.2' - supportLibsVersion = '25.1.0' + supportLibsVersion = '26.0.2' } task clean(type: Delete) { diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index aa67025..c7bfd5b 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,6 @@ -#Thu May 18 07:41:34 CEST 2017 +#Sat Sep 02 09:56:43 CEST 2017 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-4.0-milestone-1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip diff --git a/kfingerprintmanager/build.gradle b/kfingerprintmanager/build.gradle index df9771d..4bbae14 100644 --- a/kfingerprintmanager/build.gradle +++ b/kfingerprintmanager/build.gradle @@ -37,7 +37,7 @@ dependencies { exclude group: 'com.android.support', module: 'support-annotations' }) compile 'com.android.support:design:' + parent.ext.supportLibsVersion - compile "org.jetbrains.kotlin:kotlin-stdlib:1.1.2-3" + compile "org.jetbrains.kotlin:kotlin-stdlib:1.1.3-2" testCompile 'junit:junit:4.12' testCompile 'org.mockito:mockito-core:2.7.21' diff --git a/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/authentication/ui/FingerprintAuthenticationDialogFragment.kt b/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/authentication/ui/FingerprintAuthenticationDialogFragment.kt index 74afc07..19c06b8 100644 --- a/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/authentication/ui/FingerprintAuthenticationDialogFragment.kt +++ b/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/authentication/ui/FingerprintAuthenticationDialogFragment.kt @@ -30,19 +30,19 @@ class FingerprintAuthenticationDialogFragment : FingerprintBaseDialogFragment(R.id.fingerprint_dialog_backup_content) } - val password by lazy { - dialogRootView.findViewById(R.id.password) as EditText + val password: EditText by lazy { + dialogRootView.findViewById(R.id.password) } - val textInputLayout by lazy { - dialogRootView.findViewById(R.id.input_layout_password) as TextInputLayout + val textInputLayout: TextInputLayout by lazy { + dialogRootView.findViewById(R.id.input_layout_password) } - val useFingerprintFutureCheckBox by lazy { - dialogRootView.findViewById(R.id.use_fingerprint_in_future_check) as CheckBox + private val useFingerprintFutureCheckBox by lazy { + dialogRootView.findViewById(R.id.use_fingerprint_in_future_check) } private val sharedPreferences: SharedPreferences by lazy { @@ -51,12 +51,6 @@ class FingerprintAuthenticationDialogFragment : FingerprintBaseDialogFragment { - dismiss() - true - } - else -> { - textInputLayout.error = null - false + override fun onEditorAction(v: TextView?, actionId: Int, event: KeyEvent?): Boolean = + when (actionId) { + EditorInfo.IME_ACTION_GO -> { + dismiss() + true + } + else -> { + textInputLayout.error = null + false + } } - } - } override fun onFingerprintDisplayed() { fingerprintContainer.visibility = VISIBLE @@ -177,16 +170,15 @@ class FingerprintAuthenticationDialogFragment : FingerprintBaseDialogFragment() { - internal var newFingerprintEnrolled: Boolean = false + private var newFingerprintEnrolled: Boolean = false fun newFingerprintEnrolled(newFingerprintEnrolled: Boolean): Builder { this.newFingerprintEnrolled = newFingerprintEnrolled return this } - override fun createDialogFragment(): FingerprintAuthenticationDialogFragment { - return FingerprintAuthenticationDialogFragment() - } + override fun createDialogFragment(): FingerprintAuthenticationDialogFragment = + FingerprintAuthenticationDialogFragment() override fun addProperties(dialogFragment: FingerprintAuthenticationDialogFragment) { if (newFingerprintEnrolled) { @@ -194,9 +186,8 @@ class FingerprintAuthenticationDialogFragment : FingerprintBaseDialogFragment } @CallSuper - open fun inflateViews(rootView: View) { - } + open fun inflateViews(rootView: View) {} @CallSuper open fun onDialogShown() { @@ -89,7 +88,7 @@ abstract class FingerprintBaseDialogFragment } override fun close() { - dismiss() + dismissAllowingStateLoss() } override fun onCancel(dialog: DialogInterface?) { diff --git a/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/encryption/ui/FingerprintEncryptionDialogFragment.kt b/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/encryption/ui/FingerprintEncryptionDialogFragment.kt index 9c75fee..76e213b 100644 --- a/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/encryption/ui/FingerprintEncryptionDialogFragment.kt +++ b/kfingerprintmanager/src/main/kotlin/com/jesusm/kfingerprintmanager/encryption/ui/FingerprintEncryptionDialogFragment.kt @@ -16,12 +16,10 @@ class FingerprintEncryptionDialogFragment : FingerprintBaseDialogFragment Activity.bind(@IdRes idRes: Int): Lazy { @Suppress("UNCHECKED_CAST") - return unsafeLazy { findViewById(idRes) as T } + return unsafeLazy { findViewById(idRes)} } private fun unsafeLazy(initializer: () -> T) = lazy(LazyThreadSafetyMode.NONE, initializer) diff --git a/sample/build.gradle b/sample/build.gradle index 1c42f5d..5ce2357 100644 --- a/sample/build.gradle +++ b/sample/build.gradle @@ -29,7 +29,7 @@ android { dependencies { compile 'com.android.support:appcompat-v7:' + parent.ext.supportLibsVersion compile project(':kfingerprintmanager') - compile "org.jetbrains.kotlin:kotlin-stdlib:1.1.2-4" + compile "org.jetbrains.kotlin:kotlin-stdlib:1.1.3-2" } repositories { diff --git a/sample/src/main/java/jesusm/com/fingerprintmanager/sample/MainActivity.kt b/sample/src/main/java/jesusm/com/fingerprintmanager/sample/MainActivity.kt index cd7482d..7067b51 100644 --- a/sample/src/main/java/jesusm/com/fingerprintmanager/sample/MainActivity.kt +++ b/sample/src/main/java/jesusm/com/fingerprintmanager/sample/MainActivity.kt @@ -34,7 +34,7 @@ class MainActivity : AppCompatActivity() { private fun initClickListeners() { - findViewById(R.id.buttonDialogThemeLight).setOnClickListener { v -> + findViewById