Ensure miscPath is initialized for system_server modules (#678)

kiber-io · JingMatrix · web-flow · commit 846527e03ab5 · 2026-04-17T13:55:37.000+02:00
The `ensureCacheReady` method waits for the 'package' service, which is often unavailable when modules inject into `system_server`. This leads to an uninitialized `miscPath` when `getPrefsPath` is called early.

We thus call `setupMiscPath` directly in `getPrefsPath` to bypass the package service dependency, and add a null check to avoid redundant initialization.

Co-authored-by: JingMatrix &lt;jingmatrix@gmail.com&gt;
diff --git a/daemon/src/main/kotlin/org/matrix/vector/daemon/data/ConfigCache.kt b/daemon/src/main/kotlin/org/matrix/vector/daemon/data/ConfigCache.kt
@@ -83,6 +83,8 @@ object ConfigCache {
   }
 
   private fun setupMiscPath() {
+    if (state.miscPath != null) return
+
     val pathStr = PreferenceStore.getModulePrefs("lspd", 0, "config")["misc_path"] as? String
     val path =
         if (pathStr == null) {
@@ -423,7 +425,7 @@ object ConfigCache {
   }
 
   fun getPrefsPath(packageName: String, uid: Int): String {
-    ensureCacheReady()
+    setupMiscPath()
     val basePath = state.miscPath ?: throw IllegalStateException("Fatal: miscPath not initialized!")
 
     val userId = uid / PER_USER_RANGE

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,8 @@ object ConfigCache {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private fun setupMiscPath() {`
	`86`	`+ if (state.miscPath != null) return`
	`87`	`+`
`86`	`88`	`val pathStr = PreferenceStore.getModulePrefs("lspd", 0, "config")["misc_path"] as? String`
`87`	`89`	`val path =`
`88`	`90`	`if (pathStr == null) {`
`@@ -423,7 +425,7 @@ object ConfigCache {`
`423`	`425`	`}`
`424`	`426`
`425`	`427`	`fun getPrefsPath(packageName: String, uid: Int): String {`
`426`		`- ensureCacheReady()`
	`428`	`+ setupMiscPath()`
`427`	`429`	`val basePath = state.miscPath ?: throw IllegalStateException("Fatal: miscPath not initialized!")`
`428`	`430`
`429`	`431`	`val userId = uid / PER_USER_RANGE`