Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe some bugs? #77

Open
Dinngger opened this issue Dec 1, 2023 · 2 comments
Open

maybe some bugs? #77

Dinngger opened this issue Dec 1, 2023 · 2 comments

Comments

@Dinngger
Copy link

Dinngger commented Dec 1, 2023

  1. In grid_encode.py, log2 in Python is not exactly same with std::log2 in C++. This can lead to a mismatch in scale in some cases.
  2. The jt.nn.softplus is not the same as the softplus in PyTorch. I don't know if this will cause any problems.
  3. In GridEncode, JNeRF implementation doesn't have the loss scale while tcnn has it (with loss_scale=128). This will cause gradient disappearance.
  4. When computing alpha in sdf, JNeRF uses safe_clip(0.0, 1.0). I think clamp_(0.0, 1.0) should be used.
  5. The cumprod function in jittor is unsafe! Have a look at PyTorch implementation or mine in Jeuralangelo.
  6. JNeRF doesn't have the weight norm but I found it in Jittor's source. I don't know why.
@qianqiuzzz
Copy link

I met No.3 error,loss increases sharply during training. do you have any solution to fix it?

@Dinngger
Copy link
Author

Dinngger commented Sep 5, 2024

I met No.3 error,loss increases sharply during training. do you have any solution to fix it?

refer to my code, it might help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants