Marathon remove --all-packages causes multiple updates

[JohnSundell]

When running marathon remove --all-packages, multiple swift package update commands are performed under the hood, making the removal take longer than needed. Ideally only one update should occur, at the end of the process.

Current behavior:

$ marathon remove --all-packages
🏃  Removing Files...
    Updating packages...
    Removing Releases...
    Updating packages...
    Removing ShellOut...
    Updating packages...
    Removing Xgen...
    Updating packages...
    Updating packages...
🗑  Removed all packages

Expected behavior:

$ marathon remove --all-packages
🏃  Removing Files...
    Removing Releases...
    Removing ShellOut...
    Removing Xgen...
    Updating packages...
🗑  Removed all packages

[ghost]

Hi @JohnSundell

It looks like this is an issue with a default paramter. The following calls removePackage(named:) in a for loop, so the default is true.

func removeAllPackages() throws {
     for package in addedPackages {
        try removePackage(named: package.name)
     }
    try updatePackages()
}

func removePackage(named name: String, shouldUpdatePackages: Bool = true) throws -> Package {
        output.progress("Removing \(name)...")

        let packageFile = try perform(folder.file(named: name),
                                      orThrow: Error.unknownPackageForRemoval(name))

        let package = try perform(unbox(data: packageFile.read()) as Package,
                                  orThrow: Error.failedToReadPackageFile(name))

        try perform(packageFile.delete(), orThrow: Error.failedToRemovePackage(name, folder))

        if shouldUpdatePackages {
            try updatePackages()
        }

        return package
    }