fix: preserve Unlimited StreamsInbound in connmgr reconciliation

Jorropo · Jorropo · commit 63884873d0fe · 2023-03-15T04:40:16.000+01:00
Fixes ipfs#9695
diff --git a/core/node/libp2p/rcmgr_defaults.go b/core/node/libp2p/rcmgr_defaults.go
@@ -129,7 +129,9 @@ func createDefaultLimitConfig(cfg config.SwarmConfig) (limitConfig rcmgr.Concret
 		}
 
 		// Scale System.StreamsInbound as well, but use the existing ratio of StreamsInbound to ConnsInbound
-		partialLimits.System.StreamsInbound = rcmgr.LimitVal(maxInboundConns * int64(partialLimits.System.StreamsInbound) / int64(partialLimits.System.ConnsInbound))
+		if partialLimits.System.StreamsInbound != rcmgr.Unlimited {
+			partialLimits.System.StreamsInbound = rcmgr.LimitVal(maxInboundConns * int64(partialLimits.System.StreamsInbound) / int64(partialLimits.System.ConnsInbound))
+		}
 		partialLimits.System.ConnsInbound = rcmgr.LimitVal(maxInboundConns)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,9 @@ func createDefaultLimitConfig(cfg config.SwarmConfig) (limitConfig rcmgr.Concret`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`// Scale System.StreamsInbound as well, but use the existing ratio of StreamsInbound to ConnsInbound`
`132`		`- partialLimits.System.StreamsInbound = rcmgr.LimitVal(maxInboundConns * int64(partialLimits.System.StreamsInbound) / int64(partialLimits.System.ConnsInbound))`
	`132`	`+ if partialLimits.System.StreamsInbound != rcmgr.Unlimited {`
	`133`	`+ partialLimits.System.StreamsInbound = rcmgr.LimitVal(maxInboundConns * int64(partialLimits.System.StreamsInbound) / int64(partialLimits.System.ConnsInbound))`
	`134`	`+ }`
`133`	`135`	`partialLimits.System.ConnsInbound = rcmgr.LimitVal(maxInboundConns)`
`134`	`136`	`}`
`135`	`137`