Skip to content

Commit a0c9b6c

Browse files
fix(ref: #129): enhancement
1 parent bc29dab commit a0c9b6c

File tree

6 files changed

+33
-138
lines changed

6 files changed

+33
-138
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22

33
Please check if your PR fulfills the following requirements:
44

5-
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6-
- [ ] Tests for the changes have been added (for bug fixes / features)
7-
- [ ] Docs have been added / updated (for bug fixes / features)
5+
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6+
- [ ] Tests for the changes have been added (for bug fixes / features)
7+
- [ ] Docs have been added / updated (for bug fixes / features)
88

99
## PR Type
1010

1111
What kind of change does this PR introduce?
1212

1313
<!-- Please check the one that applies to this PR using "x". -->
1414

15-
- [ ] Bugfix
16-
- [ ] Feature
17-
- [ ] Code style update (formatting, local variables)
18-
- [ ] Refactoring (no functional changes, no api changes)
19-
- [ ] Build related changes
20-
- [ ] CI related changes
21-
- [ ] Documentation content changes
22-
- [ ] Other... Please describe:
15+
- [ ] Bugfix
16+
- [ ] Feature
17+
- [ ] Code style update (formatting, local variables)
18+
- [ ] Refactoring (no functional changes, no api changes)
19+
- [ ] Build related changes
20+
- [ ] CI related changes
21+
- [ ] Documentation content changes
22+
- [ ] Other... Please describe:
2323

2424
## What is the current behavior?
2525

@@ -31,8 +31,8 @@ Issue Number: N/A
3131

3232
## Does this PR introduce a breaking change?
3333

34-
- [ ] Yes
35-
- [ ] No
34+
- [ ] Yes
35+
- [ ] No
3636

3737
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
3838

CHANGELOG.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,59 +2,58 @@
22

33
### Feature
44

5-
- update dependencies
6-
5+
- update dependencies
76

87
# 19.0.0(2024-11-21)
98

109
### Feature
1110

12-
- update ng 19.x
11+
- update ng 19.x
1312

1413
# 18.0.4(2024-10-25)
1514

1615
### Feature
1716

18-
- add tailwind
19-
- change interface to type, remove prefix "I"
20-
- update dependencies
21-
- add ESLint strict rules
17+
- add tailwind
18+
- change interface to type, remove prefix "I"
19+
- update dependencies
20+
- add ESLint strict rules
2221

2322
# 17.3.2(2024-03-29)
2423

2524
### Feature
2625

27-
- change decorators to signals
26+
- change decorators to signals
2827

2928
<a name="17.0.0"></a>
3029

3130
# 17.0.0(2023-11-28)
3231

3332
### Feature
3433

35-
- update ng 17.x
34+
- update ng 17.x
3635

3736
<a name="17.0.0"></a>
3837

3938
# 16.0.1(2023-10-03)
4039

4140
### Feature
4241

43-
- update dependencies
42+
- update dependencies
4443

4544
# 16.0.0(2023-07-07)
4645

4746
### Feature
4847

49-
- update ng 16.x
48+
- update ng 16.x
5049

5150
<a name="16.0.0"></a>
5251

5352
# 15.0.0(2022-26-12)
5453

5554
### Feature
5655

57-
- update to ng15
56+
- update to ng15
5857

5958
<a name="15.0.0"></a>
6059

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ Please format code and markup in your issue using [github markdown](https://help
88

99
## Contributing to Source Code (Pull Requests)
1010

11-
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12-
- New features should be general and as simple as possible.
13-
- Breaking changes should be avoided if possible.
14-
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
11+
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12+
- New features should be general and as simple as possible.
13+
- Breaking changes should be avoided if possible.
14+
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
1515

1616
## Protractor specific rules
1717

18-
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19-
- Document public methods with jsdoc.
20-
- Be consistent with the code around you!
18+
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19+
- Document public methods with jsdoc.
20+
- Be consistent with the code around you!
2121

2222
## Commit Messages
2323

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ You can also try our NGX COPYPASTE [check](https://www.npmjs.com/package/ngx-cop
2424
## Installing
2525

2626
## npm
27+
2728
```bash
2829
$ npm install --save ngx-loader-indicator
2930
```
@@ -34,7 +35,6 @@ $ npm install --save ngx-loader-indicator
3435
$ bun install --save ngx-loader-indicator
3536
```
3637

37-
3838
## Quickstart if ngx-loader-indicator version >= 15.0.0
3939

4040
Pay attention this version works for angular >= 14.0.0

0 commit comments

Comments
 (0)