Merge pull request #12 from JuliaAI/bugfix2

fix docstring and build documentation - take II

Author: ablaom

src/FeatureSelection.jl

@@ -10,18 +10,4 @@ const MMI = MLJModelInterface
 include("models/featureselector.jl")
 include("models/rfe.jl")
 
-## Pkg Traits
-MMI.metadata_pkg.(
-    (
-        DeterministicRecursiveFeatureElimination,
-        ProbabilisticRecursiveFeatureElimination, 
-        FeatureSelector
-    ),
-    package_name       = "FeatureSelection",
-    package_uuid       = "33837fe5-dbff-4c9e-8c2f-c5612fe2b8b6",
-    package_url        = "https://github.com/JuliaAI/FeatureSelection.jl",
-    is_pure_julia      = true,
-    package_license    = "MIT"
-)
-
 end # module

src/models/featureselector.jl

@@ -87,6 +87,17 @@ MMI.metadata_model(
     load_path = "FeatureSelection.FeatureSelector"
 )
 
+## Pkg Traits
+MMI.metadata_pkg(
+    FeatureSelector,
+    package_name = "FeatureSelection",
+    package_uuid = "33837fe5-dbff-4c9e-8c2f-c5612fe2b8b6",
+    package_url = "https://github.com/JuliaAI/FeatureSelection.jl",
+    is_pure_julia = true,
+    package_license = "MIT"
+)
+
+## Docstring
 """
 $(MMI.doc_header(FeatureSelector))
 

src/models/rfe.jl

@@ -48,17 +48,17 @@ It recursively removes features, training a base model on the remaining features
 evaluating their importance until the desired number of features is selected.
 
 Construct an instance with default hyper-parameters using the syntax
-`model = RecursiveFeatureElimination(model=...)`. Provide keyword arguments to override
+`rfe_model = RecursiveFeatureElimination(model=...)`. Provide keyword arguments to override
 hyper-parameter defaults.
 
 # Training data
-In MLJ or MLJBase, bind an instance `model` to data with
+In MLJ or MLJBase, bind an instance `rfe_model` to data with
 
-    mach = machine(model, X, y)
+    mach = machine(rfe_model, X, y)
 
 OR, if the base model supports weights, as
 
-    mach = machine(model, X, y, w)
+    mach = machine(rfe_model, X, y, w)
 
 Here:
 
@@ -387,3 +387,16 @@ end
 function MMI.training_losses(model::RFE, rfe_report)
     return MMI.training_losses(model.model, rfe_report.model_report)
 end
+
+## Pkg Traits
+MMI.metadata_pkg.(
+    (
+        DeterministicRecursiveFeatureElimination,
+        ProbabilisticRecursiveFeatureElimination,
+    ),
+    package_name       = "FeatureSelection",
+    package_uuid       = "33837fe5-dbff-4c9e-8c2f-c5612fe2b8b6",
+    package_url        = "https://github.com/JuliaAI/FeatureSelection.jl",
+    is_pure_julia      = true,
+    package_license    = "MIT"
+)