-
Notifications
You must be signed in to change notification settings - Fork 15
use std names in generated functions #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hexaeder
wants to merge
1
commit into
main
Choose a base branch
from
hw/unnamify_genfunc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, creating "equivalent" models with different namespaces will result in different code inthe generated functions (because variables names appear there) which then means that two generated functions are not "equal" anymore even thogh they might be functionally equivalent. For our parallelization scheme it its important to batch equal functions. This commit tries to fix this by replacing all namespaced variable names in the generated function with standard names.
Contributor
Benchmark Resultshttps://github.com/JuliaDynamics/NetworkDynamics.jl/actions/runs/19133764150/artifacts/4486586126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, creating "equivalent" models with different namespaces will result in different code inthe generated functions (because variables names appear there) which then means that two generated functions are not "equal" anymore even thogh they might be functionally equivalent.
For our parallelization scheme it its important to batch equal functions. This commit tries to fix this by replacing all namespaced variable names in the generated function with standard names.