ImageMagick silently doesn't install on Windows

[ChrisRackauckas]

The full tale is here: JuliaPlots/Plots.jl#516. For me (and it seems like others) it's not installing (or completely installing?) on Windows. The Pkg.build("ImageMagick") command doesn't tell you it failed, but convert in the command line isn't ImageMagick, it's still a Windows command. The fix is easy: install ImageMagick using the binary which is installed in ImageMagick\\deps\\downloads, but if the build fails like this (which should be the first thing fixed, I am not familiar with working with deps like this though), it should at least give a warning and tell the user to install using the .exe.

Related SciML/DifferentialEquations.jl#58

[ibadr]

@ChrisRackauckas I just ran into a similar issue. However, I looked under ImageMagick\\deps, and I found out that apparently the build.jl script extracts all files under ImageMagick\\deps\\usr\\lib\\x64, including the convert.exe file. So, maybe for JuliaPlots/Plots.jl#516 it's better to check for the convert utility under that location as well. If so, there would be no issue with the ImageMagick package per se.

[ChrisRackauckas]

So, maybe for JuliaPlots/Plots.jl#516 it's better to check for the convert utility under that location as well.

Maybe @tbreloff has a quick implementation for that which we can test?

[Balinus]

I have the same problem here on Windows. I manually installed ImageMagick from both the deps folder and the official ImageMagick binary and I still get the error. Although, this problem seems related to Plots.jl since I can save if I use PyPlot.jl.

ImageMagick version is 0.2.3.

[timholy]

Just a comment that for those of us who don't have a Windows machine, this is very hard to debug; might require a community contribution to resolve this.

[Balinus]

I can provide more information if someone ask for specifics. Just don't know what information to provide.

[timholy]

It's more likely that the fix will have to be contributed by someone with a Windows machine, because I can't test solutions myself. If someone can encapsulate the steps they took to solve this manually into the deps/build.jl script, please do make a pull request.

[ChrisRackauckas]

Is this related? #28

Usually for this kind of stuff @musm steps in and saves the day. If he's around maybe we can work together to crank out a solution.

[timholy]

@musm is a hero on many fronts. As are you, @ChrisRackauckas.

[musm]

Ok I will look into this, but just not right now

[ChrisRackauckas]

Responding to @musm from the chat:

Pkg.add("ImageMagick") into a test leads to a bunch of fails.

Test Summary:             | Pass  Error  Total
  IO                      |    4     11     15
  Binary png              |           1      1
  Gray png                |           1      1
  Color                   |           1      1
  Colormap usage          |           1      1
  Alpha                   |           1      1
  3D TIFF (issue #307)    |           1      1
  16-bit TIFF (issue #49) |           1      1
  Clamping (issue #256)   |    2      1      3
  show(MIME)              |           1      1
  fps                     |           1      1
  ImageMeta               |           1      1
ERROR: LoadError: LoadError: Some tests did not pass: 4 passed, 0 failed, 11 errored, 0 broken.
 in finish(::Base.Test.DefaultTestSet) at .\test.jl:498
 in macro expansion; at .\test.jl:681 [inlined]
 in anonymous at .\<missing>:?
 in include_from_node1(::String) at .\loading.jl:488 (repeats 2 times)
 in process_options(::Base.JLOptions) at .\client.jl:265
 in _start() at .\client.jl:321
while loading C:\Users\Chris\.julia\v0.5\ImageMagick\test\constructed_images.jl, in expression starting on line 10
while loading C:\Users\Chris\.julia\v0.5\ImageMagick\test\runtests.jl, in expression starting on line 5
=============================[ ERROR: ImageMagick ]=============================
failed process: Process(`'C:\Users\Chris\AppData\Local\Julia-0.5.1\bin\julia' -Cx86-64 '-JC:\Users\Chris\AppData\Local\Julia-0.5.1\lib\julia\sys.dll' --compile=yes --depwarn=yes --check-bounds=yes --code-coverage=none --color=yes --compilecache=yes 'C:\Users\Chris\.julia\v0.5\ImageMagick\test\runtests.jl'`, ProcessExited(1)) [1]

================================================================================INFO: Removing AxisArrays v0.1.2

Let me see if I can re-create what I did before.

[ChrisRackauckas]

After running Pkg.build("ImageMagick") again, what I have is just a versioninfo.jl file

const libversion = v"6.9.5"

and a deps.jl file:

# This is an auto-generated file; do not edit

# Pre-hooks

# Macro to load a library
macro checked_lib(libname, path)
    ((VERSION >= v"0.4.0-dev+3844" ? Base.Libdl.dlopen_e : Base.dlopen_e)(path) == C_NULL) && error("Unable to load \n\n$libname ($path)\n\nPlease re-run Pkg.build(package), and restart Julia.")
    quote const $(esc(libname)) = $path end
end

# Load dependencies
@checked_lib libwand "C:\\Program Files\\ImageMagick-6.9.5-Q16\\CORE_RL_wand_.DLL"

# Load-hooks

function init_deps()
    ENV["MAGICK_CONFIGURE_PATH"]    = "C:\\Users\\Chris\\.julia\\v0.5\\ImageMagick\\deps\\usr\\lib\\x64"
    ENV["MAGICK_CODER_MODULE_PATH"] = "C:\\Users\\Chris\\.julia\\v0.5\\ImageMagick\\deps\\usr\\lib\\x64"
end
init_deps()

However, there is no usr folder. Now it doesn't seem to download anything!

[ChrisRackauckas]

When running the build.jl commands directly in the REPL, I see:

julia>     magick_tmpdir   = BinDeps.downloadsdir(libwand)
"C:\\Users\\Chris\\AppData\\Local\\deps\\downloads"

julia>     magick_url      = "$(magick_base)/$(magick_exe)"
"http://www.imagemagick.org/download/binaries/ImageMagick-6.9.8-3-Q16-x64-dll.exe"

julia>     magick_libdir   = joinpath(BinDeps.libdir(libwand), OS_ARCH)
"C:\\Users\\Chris\\AppData\\Local\\deps\\usr\\lib\\x64"
julia>     innounp_url     = "https://bintray.com/artifact/download/julialang/generic/innounp.exe"
"https://bintray.com/artifact/download/julialang/generic/innounp.exe"

The BuildProcess doesn't seem to do anything though. Its output is:

julia>     provides(BuildProcess,
               (@build_steps begin
                   CreateDirectory(magick_tmpdir)
                   CreateDirectory(magick_libdir)
                   FileDownloader(magick_url, joinpath(magick_tmpdir, magick_exe))
                   FileDownloader(innounp_url, joinpath(magick_tmpdir, "innounp.exe"))
                   @build_steps begin
                       ChangeDirectory(magick_tmpdir)
                       info("Installing ImageMagick library")
                       `innounp.exe -q -y -b -e -x -d$(magick_libdir) $(magick_exe)`
                   end
               end),
               libwand, os = :Windows, unpacked_dir = magick_libdir, preload = initfun)
INFO: Installing ImageMagick library
1-element Array{Tuple{BinDeps.DependencyProvider,Dict{Symbol,Any}},1}:
 (Simple Build Process,Dict{Symbol,Any}(Pair{Symbol,Any}(:unpacked_dir,"C:\\Users\\Chris\\AppData\\Local\\deps\\usr\\lib\\x64"),Pair{Symbol,Any}(:os,:Windows),Pair{Symbol,Any}(:preload,"function init_deps()\n    ENV[\"MAGICK_CONFIGURE_PATH\"]    = \"C:\\\\Users\\\\Chris\\\\AppData\\\\Local\\\\deps\\\\usr\\\\lib\\\\x64\"\n    ENV[\"MAGICK_CODER_MODULE_PATH\"] = \"C:\\\\Users\\\\Chris\\\\AppData\\\\Local\\\\deps\\\\usr\\\\lib\\\\x64\"\nend\ninit_deps()\n")))

I'm a little bit out of my depth here when it comes to BinDeps, so please guide me if you see anything. But it doesn't seem to error, yet it doesn't seem to download anything or even make the directories.

[timholy]

In case it's not widely known (and in case it's useful), on Linux when I want to conduct Pkg experiments I often start with a fresh pkg directory. I can do that without messing up my "real" directory with

$ JULIA_PKGDIR=/tmp/pkgs julia

Not sure whether something like that is possible/helpful on Windows.