segfault in new fs__chmod code

[vtjnash]

Seems this was introduced in 794bfdf, as NULL is documented as a valid result for the variable on that line¹, but that is not handled here.

see JuliaLang/julia#41642 (comment) for reproducer

Footnotes

1. fs__chmod at src/win/fs.c:2361 ↩

[KrishnaPG]

Encountering similar error while adding package to a new installation (v1.8.3 on Windows 10 64-bit)

Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.

Exception: EXCEPTION_ACCESS_VIOLATION at 0x7ff8945c35e2 -- fs__chmod at /workspace/srcdir/libuv\src/win\fs.c:2372
in expression starting at none:0
fs__chmod at /workspace/srcdir/libuv\src/win\fs.c:2372
uv__fs_work at /workspace/srcdir/libuv\src/win\fs.c:3218
uv_fs_chmod at /workspace/srcdir/libuv\src/win\fs.c:3774
jl_fs_chmod at C:/workdir/src\jl_uv.c:390
#chmod#34 at .\file.jl:1149
chmod at .\file.jl:1148 [inlined]
#26 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\extract.jl:98
#read_tarball#47 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\extract.jl:399
jfptr_YY.read_tarballYY.47_62324.clone_1 at C:\Users\x\AppData\Local\Programs\Julia-1.8.3\lib\julia\sys.dll (unknown line)
read_tarball##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\extract.jl:333
#extract_tarball#25 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\extract.jl:58
extract_tarball##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\extract.jl:49
unknown function (ip: 0000022d0783e4b1)
#85 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:237
arg_write at C:\workdir\usr\share\julia\stdlib\v1.8\ArgTools\src\ArgTools.jl:134
#84 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:236 [inlined]
arg_mkdir at C:\workdir\usr\share\julia\stdlib\v1.8\ArgTools\src\ArgTools.jl:185
#83 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:232 [inlined]
#open#735 at .\process.jl:427
jfptr_YY.openYY.735_39289.clone_1 at C:\Users\x\AppData\Local\Programs\Julia-1.8.3\lib\julia\sys.dll (unknown line)
open at .\process.jl:414
arg_read at C:\workdir\usr\share\julia\stdlib\v1.8\ArgTools\src\ArgTools.jl:75 [inlined]
#extract#82 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:231
extract##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:218 [inlined]
#extract#89 at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:255 [inlined]
extract##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Tar\src\Tar.jl:248
unknown function (ip: 0000022d0783e29a)
#unpack#21 at C:\workdir\usr\share\julia\stdlib\v1.8\Pkg\src\PlatformEngines.jl:389
unpack##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Pkg\src\PlatformEngines.jl:384 [inlined]
#install_archive#33 at C:\workdir\usr\share\julia\stdlib\v1.8\Pkg\src\Operations.jl:535
install_archive##kw at C:\workdir\usr\share\julia\stdlib\v1.8\Pkg\src\Operations.jl:512
jfptr_install_archiveYY.YY.kw_70293.clone_1 at C:\Users\x\AppData\Local\Programs\Julia-1.8.3\lib\julia\sys.dll (unknown line)
macro expansion at C:\workdir\usr\share\julia\stdlib\v1.8\Pkg\src\Operations.jl:761 [inlined]
#46 at .\task.jl:484
jfptr_YY.46_71618.clone_1 at C:\Users\x\AppData\Local\Programs\Julia-1.8.3\lib\julia\sys.dll (unknown line)
jl_apply at C:/workdir/src\julia.h:1839 [inlined]
start_task at C:/workdir/src\task.c:931
Allocations: 2503479 (Pool: 2501812; Big: 1667); GC: 4

ERROR: The pipe is being closed.

Was trying to run add Graphs and the above error happened, crashing the terminal

[vtjnash]

#16 is not merged yet

[Keno]

Is this fixed?

[staticfloat]

Yes: https://github.com/JuliaLang/libuv/pull/41/files#diff-8065cb0410903ca646b8166581561f1b3d1b9c68d5129d9604aa69ac3aa5591aR2371