Return array in setindex (#186)

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockBandedMatrices"
 uuid = "ffab5731-97b5-5995-9138-79e8c1846df0"
-version = "0.12.9"
+version = "0.12.10"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/BlockSkylineMatrix.jl

@@ -408,7 +408,7 @@ end
     bi = findblockindex.(axes(A), (i,j))
     V = view(A, block.(bi)...)
     @inbounds V[blockindex.(bi)...] = convert(T, v)::T
-    return v
+    return A
 end
 
 ############
@@ -490,11 +490,10 @@ end
         # TODO: What to do if b_start == 0 ?
         b_stride = A.block_sizes.block_strides[J]
         A.data[b_start + k-1 + (j-1)*b_stride ] = v
-    elseif iszero(v) # allow setindex for 0 data
-        v
-    else
+    elseif !iszero(v) # allow setindex for 0 data
         throw(BandError(A, J-K))
     end
+    return V
 end
 
 """

test/test_blockbanded.jl

@@ -82,7 +82,8 @@ import BlockBandedMatrices: MemoryLayout, ColumnMajor, BroadcastStyle,
 
         A[1,1] = -5
         @test A[1,1] == -5
-        A[1,3] = -6
+        # setindex! should return the array
+        @test setindex!(A, -6, 1, 3) === A
         @test A[1,3] == -6
 
         A[Block(3,4)] = Matrix(Ones{Int}(3,4))
@@ -95,6 +96,10 @@ import BlockBandedMatrices: MemoryLayout, ColumnMajor, BroadcastStyle,
         V = view(ret, Block(1), Block(2))
         V[1,1] = 2
         @test ret[1,2] == 0
+
+        # setindex! should return the array
+        @test setindex!(V, 4, 1, 2) === V
+        @test V[1,2] == 4
     end
 
     @testset "blockcol/rowsupport" begin