Empty blockcol/rowsupport (#112)

* Add tezsts

* Update CompatHelper.yml

Author: dlfivefifty

.github/workflows/CompatHelper.yml

@@ -1,25 +1,26 @@
 name: CompatHelper
-
 on:
   schedule:
-    - cron: '00 * * * *'
-
+    - cron: 0 0 * * *
+  workflow_dispatch:
 jobs:
-  build:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        julia-version: [1.2.0]
-        julia-arch: [x86]
-        os: [ubuntu-latest]
+  CompatHelper:
+    runs-on: ubuntu-latest
     steps:
-      - uses: julia-actions/setup-julia@latest
-        with:
-          version: ${{ matrix.julia-version }}
-      - name: Install dependencies
-        run: julia -e 'using Pkg; Pkg.add(Pkg.PackageSpec(name = "CompatHelper", url = "https://github.com/bcbi/CompatHelper.jl.git"))'
-      - name: CompatHelper.main
+      - name: "Install CompatHelper"
+        run: |
+          import Pkg
+          name = "CompatHelper"
+          uuid = "aa819f21-2bde-4658-8897-bab36330d9b7"
+          version = "2"
+          Pkg.add(; name, uuid, version)
+        shell: julia --color=yes {0}
+      - name: "Run CompatHelper"
+        run: |
+          import CompatHelper
+          CompatHelper.main()
+        shell: julia --color=yes {0}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          JULIA_DEBUG: CompatHelper
-        run: julia -e 'using CompatHelper; CompatHelper.main()'
+          COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }}
+          # COMPATHELPER_PRIV: ${{ secrets.COMPATHELPER_PRIV }}

Project.toml

@@ -1,6 +1,6 @@
 name = "BlockBandedMatrices"
 uuid = "ffab5731-97b5-5995-9138-79e8c1846df0"
-version = "0.10.5"
+version = "0.10.6"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/AbstractBlockBandedMatrix.jl

@@ -81,8 +81,8 @@ blockbanded_blockrowstop(A, i::BlockRange) = blockbanded_blockrowstop(A, maximum
 
 const AllBlockBandedLayout{UPLO,UNIT} = Union{AbstractBlockBandedLayout,TriangularLayout{UPLO,UNIT,<:AbstractBlockBandedLayout}}
 
-@inline blockcolsupport(::AllBlockBandedLayout, A, i) = blockbanded_blockcolstart(A,i):blockbanded_blockcolstop(A,i)
-@inline blockrowsupport(::AllBlockBandedLayout, A, i) = blockbanded_blockrowstart(A,i):blockbanded_blockrowstop(A,i)
+@inline blockcolsupport(::AllBlockBandedLayout, A, i) = isempty(i) ? (Block(1):Block(0)) : blockbanded_blockcolstart(A,i):blockbanded_blockcolstop(A,i)
+@inline blockrowsupport(::AllBlockBandedLayout, A, i) = isempty(i) ? (Block(1):Block(0)) : blockbanded_blockrowstart(A,i):blockbanded_blockrowstop(A,i)
 
 
 # length of i-the column/row

test/test_blockbanded.jl

@@ -97,16 +97,20 @@ import Base.Broadcast: materialize!
         A = BlockBandedMatrix{Int}(undef, rows,cols, (l,u))
         A.data .= 1:length(A.data)
 
-        @test blockrowsupport(A, 1) == Block.(1:3)
+        @test @inferred(blockrowsupport(A, 1)) == Block.(1:3)
         @test blockrowsupport(A, 2) == Block.(1:4)
         @test blockrowsupport(A, 3) == Block.(2:4)
-        @test blockrowsupport(A, Block.(3:4)) == Block.(2:4)
 
-        @test blockcolsupport(A, 1) == Block.(1:2)
+        @test @inferred(blockcolsupport(A, 1)) == Block.(1:2)
         @test blockcolsupport(A, 2) == Block.(1:3)
         @test blockcolsupport(A, 3) == Block.(1:4)
         @test blockcolsupport(A, 4) == Block.(2:4)
-        @test blockcolsupport(A, Block.(1:2)) == Block.(1:3)
+
+        @test @inferred(blockrowsupport(A, Block.(3:4))) == Block.(2:4)
+        @test @inferred(blockcolsupport(A, Block.(1:2))) == Block.(1:3)
+        
+        @test @inferred(blockcolsupport(A, Block.(1:0))) == Block.(1:0)
+        @test @inferred(blockcolsupport(A, 1:0)) == Block.(1:0)
     end
 
     @testset "block-banded matrix interface for blockranges" begin