Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching over to using @testsets #251

Open
rofinn opened this issue Apr 25, 2017 · 5 comments
Open

Switching over to using @testsets #251

rofinn opened this issue Apr 25, 2017 · 5 comments

Comments

@rofinn
Copy link
Member

rofinn commented Apr 25, 2017

The @testset macro (introduced in 0.5) provides nicer test reporting.

@ararslan
Copy link
Member

Yes, this would be good. It's been on my to-do list for a while but I haven't gotten around to it. A PR would be welcome if you're interested in taking it on.

@rofinn
Copy link
Member Author

rofinn commented Apr 25, 2017

Sure. I'm going to need to change a bunch of tests for #250, so maybe I'll just roll it in with that.

@ararslan
Copy link
Member

That'd be fine, though having it as a separate PR (or at least a separate commit) would make it easier to review.

@rofinn
Copy link
Member Author

rofinn commented Apr 25, 2017

Yeah, I was thinking I'd just adding an extra commit once that PR is ready.

@sbromberger
Copy link

Just a heads-up - if you wrap all your tests in nested testsets, you won't see progress in Travis - the output is delayed until all tests are complete. (This can be a disadvantage.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants