Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods from deviation.jl to Distances.jl? #289

Open
rofinn opened this issue Jul 25, 2017 · 4 comments
Open

Move methods from deviation.jl to Distances.jl? #289

rofinn opened this issue Jul 25, 2017 · 4 comments
Assignees
@rofinn

Comments

@rofinn
Copy link
Member

rofinn commented Jul 25, 2017

I'm just wondering if some of the L1 and L2 distance methods should be moved to Distances.jl? Looks like that package already has an implementation of the Chebyshev and KLDivergence.
@ararslan
Copy link
Member

Yes, see JuliaStats/Distances.jl#45

@rofinn
Copy link
Member Author

rofinn commented Jul 25, 2017

Thanks, I definitely missed that.

@rofinn rofinn self-assigned this Jul 25, 2017
@rofinn rofinn closed this as completed Jul 25, 2017
@ararslan
Copy link
Member

Easy to miss

@ararslan
Copy link
Member

ararslan commented Aug 1, 2017

Now that my PR over there has been merged, we can now deprecate the distances here that have been moved.

@ararslan ararslan reopened this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rofinn rofinn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rofinn @ararslan