Skip to content

Commit 762c4fe

Browse files
committed
Update macos app bundle id
1 parent 5d1a711 commit 762c4fe

File tree

4 files changed

+41
-14
lines changed

4 files changed

+41
-14
lines changed

jccm/forge.config.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ let archOption;
1010

1111
module.exports = {
1212
packagerConfig: {
13+
appBundleId: 'net.juniper.juniper-cloud-connection-manager',
1314
asar: true,
1415
icon: './assets/icons/AppIcon', // Path without the extension
1516
osxSign: {
@@ -49,11 +50,14 @@ module.exports = {
4950
format: 'ULFO', // Optional: Customize DMG format
5051
overwrite: true,
5152
},
52-
},
53+
},
5354
{
5455
name: '@electron-forge/maker-squirrel',
5556
config: {
56-
iconUrl: `file://${path.resolve(__dirname, 'assets/icons/AppIcon.ico')}`, // Local file URL for Windows
57+
iconUrl: `file://${path.resolve(
58+
__dirname,
59+
'assets/icons/AppIcon.ico'
60+
)}`, // Local file URL for Windows
5761
setupIcon: path.join(__dirname, 'assets/icons/AppIcon.ico'), // Path to the .ico file for Windows
5862
overwrite: true,
5963
out: path.join(__dirname, 'out/make/windows-x64'),
@@ -95,8 +99,12 @@ module.exports = {
9599
archOption = arch ? arch : process.arch;
96100
},
97101
preMake: async (config) => {
98-
const makerPkg = config.makers.find((maker) => maker.name === '@electron-forge/maker-pkg');
99-
const makerDmg = config.makers.find((maker) => maker.name === '@electron-forge/maker-dmg');
102+
const makerPkg = config.makers.find(
103+
(maker) => maker.name === '@electron-forge/maker-pkg'
104+
);
105+
const makerDmg = config.makers.find(
106+
(maker) => maker.name === '@electron-forge/maker-dmg'
107+
);
100108

101109
const name = `jccm-darwin-${archOption}`;
102110

jccm/package-lock.json

+27
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jccm/package.json

+1-9
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@
33
"productName": "Juniper Cloud Connection Manager",
44
"description": "Juniper Cloud Connection Manager",
55
"version": "1.2.3",
6-
"build": {
7-
"publish": [
8-
{
9-
"provider": "github",
10-
"owner": "simonrho",
11-
"repo": "juniper-jccm"
12-
}
13-
]
14-
},
156
"main": ".webpack/main",
167
"scripts": {
178
"start": "pkill -9 node; nodemon --watch ./src --ext js,json --ignore ./src/Frontend/ --exec 'electron-forge start'",
@@ -92,6 +83,7 @@
9283
"socket.io-client": "^4.7.5",
9384
"ssh2": "^1.15.0",
9485
"tough-cookie": "^4.1.4",
86+
"update-electron-app": "^3.0.0",
9587
"uuid": "^9.0.1",
9688
"validator": "^13.12.0",
9789
"xlsx": "^0.18.5",

jccm/src/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ const createWindow = () => {
5151
console.log('Window Created');
5252
};
5353

54-
5554
// This method will be called when Electron has finished
5655
// initialization and is ready to create browser windows.
5756
// Some APIs can only be used after this event occurs.
5857
app.whenReady().then(() => {
5958
setupApiHandlers(); // Set up IPC handlers
6059
createWindow();
6160

61+
6262
// On OS X it's common to re-create a window in the app when the
6363
// dock icon is clicked and there are no other windows open.
6464
app.on('activate', () => {

0 commit comments

Comments
 (0)