Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disasm view UX issues #692

Open
svalaskevicius opened this issue Feb 16, 2025 · 5 comments
Open

Disasm view UX issues #692

svalaskevicius opened this issue Feb 16, 2025 · 5 comments

Comments

@svalaskevicius
Copy link

svalaskevicius commented Feb 16, 2025

Disassembler view is very hard to use:

  1. source view on the left only shows top level function, and all inlined functions are not shown (e.g from another source file) - so I can only see the disassembled view for those
  2. columns are not resizable and the source is cut of by other columns with no way to get it to appear. would be nice if I could resize columns manually

To illustrate, there is a lot of disassembled stuff here, but the source view is stuck at the few lines on the left:

Image

Other than these, hotspot is becoming a really nice tool! thanks :)

@milianw
Copy link
Member

milianw commented Mar 1, 2025

I think @lievenhey was experimenting with one approach to improve the situation over at #494 but it's very non-trivial since the normal information we get from objdump isn't good enough for what we want to do I fear.

@svalaskevicius
Copy link
Author

hmm the inlines are detected well as seen on the right side.

I only wish the left side would not be stuck at that single source file and I could either select another or it would shift to another source file based on which line is selected on the right side.

also the column widths.. should hopefully be simple to allow users to expand the length of the source lines manually?

@GitMensch
Copy link
Contributor

For the source view - are you really sure you (always) need all those columns for your analysis?
If not, then just right-click on those and disable them, providing more space for the code (the UI records your last setup and you can always use right-click on the header line to get them back as needed).

@svalaskevicius
Copy link
Author

I tried. there is a lot of right clicks involved and it doesn't remember when the view is reopened..

why not to allow adjusting the width?

@milianw
Copy link
Member

milianw commented Mar 3, 2025

I agree, some of these suggestions sound nice and easy. The file annotation navigation may be a bit tricky, depending on what we currently do - it's been too long since I investigated this in detail. Still, I split this off into its own subtask now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants