Merge pull request #116 from Yuvraj-Sarathe/config

Config

Author: utkarsh232005

src/__tests__/config.test.ts

@@ -89,13 +89,72 @@ describe('config command', () => {
     expect(webhookPrompt.validate('not-a-webhook')).toBe('Must be a valid Discord webhook URL (including ID and Token)');
   });
 
+  it('should detect existing config and prompt for reconfiguration — cancel keeps current config', async () => {
+    vi.mocked(configUtils.getConfig).mockReturnValue({ notification_service: 'discord' });
+    vi.mocked(tui.select).mockResolvedValueOnce('no'); // decline reconfiguration
+
+    await program.parseAsync(['node', 'test', 'config', 'setup']);
+
+    expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Current notification service is set to'));
+    expect(tui.select).toHaveBeenCalledTimes(1); // only reconfiguration prompt
+    expect(configUtils.setConfig).not.toHaveBeenCalled();
+  });
+
+  it('should proceed with setup when user confirms reconfiguration', async () => {
+    vi.mocked(configUtils.getConfig).mockReturnValue({ notification_service: 'discord' });
+    vi.mocked(tui.select)
+      .mockResolvedValueOnce('yes') // confirm reconfiguration
+      .mockResolvedValueOnce('discord'); // select discord service
+    vi.mocked(tui.input).mockResolvedValue('https://discord.com/api/webhooks/123456789/token-here');
+
+    await program.parseAsync(['node', 'test', 'config', 'setup']);
+
+    expect(tui.select).toHaveBeenCalledTimes(2); // reconfiguration + service selection
+    expect(configUtils.setConfig).toHaveBeenCalledWith('notification_service', 'discord');
+    expect(configUtils.setConfig).toHaveBeenCalledWith('discord_webhook', 'https://discord.com/api/webhooks/123456789/token-here');
+  });
+
+  it('should skip reconfiguration prompt when no existing config', async () => {
+    vi.mocked(configUtils.getConfig).mockReturnValue({});
+    vi.mocked(tui.select).mockResolvedValue('none');
+
+    await program.parseAsync(['node', 'test', 'config', 'setup']);
+
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(
+      expect.stringContaining('Current notification service is set to'),
+    );
+    expect(tui.select).toHaveBeenCalledTimes(1); // only service selection
+    expect(configUtils.setConfig).toHaveBeenCalledWith('notification_service', 'none');
+  });
+
+  it('should handle select rejection gracefully during setup', async () => {
+    vi.mocked(tui.select).mockRejectedValueOnce(new Error('select failed'));
+
+    await program.parseAsync(['node', 'test', 'config', 'setup']);
+
+    expect(consoleErrorSpy).toHaveBeenCalledWith(expect.stringContaining('select failed'));
+    expect(configUtils.setConfig).not.toHaveBeenCalled();
+  });
+
+  it('should handle setConfig failure gracefully during setup', async () => {
+    vi.mocked(tui.select).mockResolvedValue('discord');
+    vi.mocked(tui.input).mockResolvedValue('https://discord.com/api/webhooks/123456789/token-here');
+    // Use mockImplementationOnce to avoid polluting subsequent tests
+    vi.mocked(configUtils.setConfig).mockImplementationOnce(() => { throw new Error('write failed'); });
+
+    await program.parseAsync(['node', 'test', 'config', 'setup']);
+
+    expect(consoleErrorSpy).toHaveBeenCalledWith(expect.stringContaining('write failed'));
+  });
+
   it('should call select, multiple inputs and setConfig on email setup without password', async () => {
     vi.mocked(tui.select).mockResolvedValue('email');
     vi.mocked(tui.input)
       .mockResolvedValueOnce('smtp.gmail.com') // host
       .mockResolvedValueOnce('587')            // port
       .mockResolvedValueOnce('user@test.com')  // user
-      .mockResolvedValueOnce('to@test.com');   // to
+      .mockResolvedValueOnce('to@test.com')    // to
+      .mockResolvedValueOnce('');              // password (empty)
 
     await program.parseAsync(['node', 'test', 'config', 'setup']);
 
@@ -112,41 +171,78 @@ describe('config command', () => {
     expect(guideOrder).toBeLessThan(firstInputOrder());
   });
 
-  it('should not ask for or persist SMTP password during email setup', async () => {
-    vi.mocked(tui.select).mockResolvedValue('email');
-    vi.mocked(tui.input)
-      .mockResolvedValueOnce('smtp.gmail.com') // host
-      .mockResolvedValueOnce('587')            // port
-      .mockResolvedValueOnce('user@test.com')  // user
-      .mockResolvedValueOnce('to@test.com');   // to
+  it('should save email_password if provided during email setup', async () => {
+  vi.mocked(tui.select).mockResolvedValue('email');
+  vi.mocked(tui.input)
+    .mockResolvedValueOnce('smtp.gmail.com') // host
+    .mockResolvedValueOnce('587')            // port
+    .mockResolvedValueOnce('user@test.com')  // user
+    .mockResolvedValueOnce('to@test.com')    // to
+    .mockResolvedValueOnce('pass123');       // password
 
-    await program.parseAsync(['node', 'test', 'config', 'setup']);
+  await program.parseAsync(['node', 'test', 'config', 'setup']);
 
-    expect(tui.input).toHaveBeenCalledTimes(4);
-    expect(configUtils.setConfig).not.toHaveBeenCalledWith('email_password', expect.any(String));
-    expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('KDM_SMTP_PASSWORD'));
-  });
+  // Find the call that passed 'email_password' instead of assuming index
+  const passwordCall = vi.mocked(configUtils.setConfig).mock.calls.find(
+    call => call[0] === 'email_password'
+  );
+  expect(passwordCall).toBeDefined();
+  expect(passwordCall?.[1]).toBe('pass123');
+});
 
-  it('should require an SMTP host during email setup', async () => {
-    vi.mocked(tui.select).mockResolvedValue('email');
-    vi.mocked(tui.input)
-      .mockResolvedValueOnce('smtp.gmail.com')
-      .mockResolvedValueOnce('587')
-      .mockResolvedValueOnce('user@test.com')
-      .mockResolvedValueOnce('to@test.com');
+it('should require an SMTP host during email setup and validate optional SMTP password', async () => {
+  vi.mocked(tui.select).mockResolvedValue('email');
+  vi.mocked(tui.input)
+    .mockResolvedValueOnce('smtp.gmail.com')
+    .mockResolvedValueOnce('587')
+    .mockResolvedValueOnce('user@test.com')
+    .mockResolvedValueOnce('to@test.com')
+    .mockResolvedValueOnce('');
 
-    await program.parseAsync(['node', 'test', 'config', 'setup']);
+  await program.parseAsync(['node', 'test', 'config', 'setup']);
 
-    const smtpHostPrompt = vi.mocked(tui.input).mock.calls[0][0];
-    expect(smtpHostPrompt.validate('')).toBe('Host is required');
-  });
+  const smtpHostPrompt = vi.mocked(tui.input).mock.calls[0][0];
+  expect(smtpHostPrompt.validate('')).toBe('Host is required');
+
+  // Find the password prompt by looking for the last input call
+  const passwordPromptIndex = vi.mocked(tui.input).mock.calls.length - 1;
+  const smtpPasswordPrompt = vi.mocked(tui.input).mock.calls[passwordPromptIndex][0];
+  expect(smtpPasswordPrompt.validate('')).toBe(true);
+  expect(smtpPasswordPrompt.validate('anything')).toBe(true);
+});
 
   it('should call setConfig on config set', async () => {
     await program.parseAsync(['node', 'test', 'config', 'set', 'alert_email', 'test@test.com']);
     expect(configUtils.setConfig).toHaveBeenCalledWith('alert_email', 'test@test.com');
     expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Set alert_email to test@test.com'));
   });
 
+  it('should show deprecation warning when setting credential key via config set', async () => {
+    await program.parseAsync(['node', 'test', 'config', 'set', 'discord_webhook', 'https://discord.com/api/webhooks/test']);
+    expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Deprecation warning'));
+    expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('kdm config setup'));
+    expect(configUtils.setConfig).toHaveBeenCalled(); // still executes (soft deprecation)
+  });
+
+  it('should show deprecation warning for all credential keys', async () => {
+    const credentialKeys = ['notification_service', 'discord_webhook', 'email_host', 'email_port', 'email_user', 'email_to'];
+    for (const key of credentialKeys) {
+      vi.clearAllMocks();
+      // email_port gets parsed to int by the existing handler logic
+      const testValue = key === 'email_port' ? '587' : 'test-value';
+      const expectedValue = key === 'email_port' ? 587 : testValue;
+      await program.parseAsync(['node', 'test', 'config', 'set', key, testValue]);
+      expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Deprecation warning'));
+      expect(configUtils.setConfig).toHaveBeenCalledWith(key, expectedValue);
+    }
+  });
+
+  it('should not show deprecation warning for non-credential keys', async () => {
+    await program.parseAsync(['node', 'test', 'config', 'set', 'alert_cooldown', '300']);
+    expect(consoleLogSpy).not.toHaveBeenCalledWith(expect.stringContaining('Deprecation warning'));
+    expect(configUtils.setConfig).toHaveBeenCalledWith('alert_cooldown', 300);
+  });
+
   it('should parse integer for alert_cooldown', async () => {
     await program.parseAsync(['node', 'test', 'config', 'set', 'alert_cooldown', '123']);
     expect(configUtils.setConfig).toHaveBeenCalledWith('alert_cooldown', 123);