Skip to content

Doesn't use ClickThroughBlocker #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dunbaratu opened this issue May 9, 2020 · 2 comments
Open

Doesn't use ClickThroughBlocker #2697

Dunbaratu opened this issue May 9, 2020 · 2 comments
Labels
bug Weird outcome is probably not what the mod programmer expected.

Comments

@Dunbaratu
Copy link
Member

Dunbaratu commented May 9, 2020 •
edited
Loading

kOS uses its own homemade system for dealing with keyboard focus and click detection, but this system does not make use of the ClickThroughBlocker mod that all of Linuxgurugamer's mods use.

Looking at the code for it, the way that ClickThroughBlocker is designed only really works well if all the mods are participants in its system. (So essentially once some mods are using it, all the other mods have to also be using it too.)

If this is addressed, then Issue #2694 should be tested with this change. I doubt it's the same problem, but because it deals with window focus, one could affect the other.
@Dunbaratu Dunbaratu changed the title Doesn't use ClickThruBlocker Doesn't use ClickThroughBlocker May 9, 2020
Dunbaratu added a commit that referenced this issue Aug 7, 2020
@Dunbaratu
Merge this only AFTER the a ZIP release of #2697.
7969136 
Do NOT merge this PR until AFTER branch
"fixes_issue_2697_ClickThroughBlocker" finds its way
all the way into a public release in a ZIP file.

The reason is complex, but it has to do with how
CKAN's bot crawls and reads the kOS.netkan file.
As soon as this edit finds its way into the master
branch, CKAN's bot will see it within a half hour.
If it sees this edit *before* we make a release
from that master branch, it will end up associating
these edits with the previous kOS release, and
falsely adding this new dependency to it.

In general all edits to kOS.netkan MUST wait until
after there's been a release made for those edits.
@Dunbaratu Dunbaratu added the bug Weird outcome is probably not what the mod programmer expected. label Aug 8, 2020
@Dunbaratu
Copy link
Member Author

Dunbaratu commented Aug 8, 2020 •
edited
Loading

Was addressed by #2729

@Dunbaratu
Copy link
Member Author

Dunbaratu commented Dec 30, 2020 •
edited
Loading

Because I had to revert PR #2729 due to needing to get a release out even though ClickThroughBlocker is needing an API change for me to use it and it doesn't look like it will be addressed soon, this isn't really closed after all. Re-opening it so it gets remembered for later.

@Dunbaratu Dunbaratu reopened this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Weird outcome is probably not what the mod programmer expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dunbaratu