Skip to content

Commit 6c95154

Browse files
committed
Add default value for configs
1 parent 408ba9c commit 6c95154

File tree

7 files changed

+18
-26
lines changed

7 files changed

+18
-26
lines changed

src/main/java/com/lx862/svrutil/data/JoinMessage.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.google.gson.JsonObject;
55
import eu.pb4.placeholders.api.TextParserUtils;
66
import net.minecraft.text.Text;
7+
import net.minecraft.util.JsonHelper;
78

89
import java.util.ArrayList;
910
import java.util.List;
@@ -25,10 +26,10 @@ public JoinMessage(Text title, Text subtitle, Text joinMessage, int delayTick, L
2526

2627
public static JoinMessage fromJson(JsonObject jsonObject) {
2728
List<Integer> permLevels = new ArrayList<>();
28-
int delayTick = jsonObject.has("delayTick") ? jsonObject.get("delayTick").getAsInt() : 0;
29-
Text title = jsonObject.has("title") ? TextParserUtils.formatText(jsonObject.get("title").getAsString()) : null;
30-
Text subtitle = jsonObject.has("subtitle") ? TextParserUtils.formatText(jsonObject.get("subtitle").getAsString()) : null;
31-
Text joinMessage = jsonObject.has("message") ? TextParserUtils.formatText(jsonObject.get("message").getAsString()) : null;
29+
Text title = JsonHelper.hasString(jsonObject, "title") ? TextParserUtils.formatText(JsonHelper.getString(jsonObject, "title")) : null;
30+
Text subtitle = JsonHelper.hasString(jsonObject, "subtitle") ? TextParserUtils.formatText(JsonHelper.getString(jsonObject, "subtitle")) : null;
31+
Text joinMessage = JsonHelper.hasString(jsonObject, "message") ? TextParserUtils.formatText(JsonHelper.getString(jsonObject, "message")) : null;
32+
int delayTick = JsonHelper.getInt(jsonObject, "delayTick", 0);
3233

3334
try {
3435
jsonObject.get("permLevels").getAsJsonArray().forEach(e -> {

src/main/java/com/lx862/svrutil/feature/FancyMessageFeature.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public void readConfig(JsonObject jsonObject) {
1515

1616
@Override
1717
public JsonObject generateConfig() {
18-
JsonObject jsonObject = super.generateConfig();
19-
return jsonObject;
18+
return super.generateConfig();
2019
}
2120
}

src/main/java/com/lx862/svrutil/feature/Feature.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import net.fabricmc.fabric.api.networking.v1.PacketSender;
55
import net.minecraft.server.MinecraftServer;
66
import net.minecraft.server.network.ServerPlayNetworkHandler;
7+
import net.minecraft.util.JsonHelper;
78

89
public abstract class Feature {
910
public final String displayName;
@@ -16,7 +17,7 @@ public Feature(String displayName, String configName) {
1617
}
1718

1819
public void readConfig(JsonObject jsonObject) {
19-
this.enabled = jsonObject.has("enabled") && jsonObject.get("enabled").getAsBoolean();
20+
this.enabled = JsonHelper.getBoolean(jsonObject, "enabled", false);
2021
}
2122

2223
public JsonObject generateConfig() {

src/main/java/com/lx862/svrutil/feature/HungerFeature.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.google.gson.JsonObject;
44
import net.minecraft.server.MinecraftServer;
5+
import net.minecraft.util.JsonHelper;
56

67
public class HungerFeature extends Feature {
78
public int minHunger = 0;
@@ -14,8 +15,8 @@ public HungerFeature() {
1415
@Override
1516
public void readConfig(JsonObject jsonObject) {
1617
super.readConfig(jsonObject);
17-
this.minHunger = jsonObject.get("minLevel").getAsInt();
18-
this.maxHunger = jsonObject.get("maxLevel").getAsInt();
18+
this.minHunger = JsonHelper.getInt(jsonObject, "minLevel", minHunger);
19+
this.maxHunger = JsonHelper.getInt(jsonObject, "maxLevel", maxHunger);
1920
}
2021

2122
@Override

src/main/java/com/lx862/svrutil/feature/TextOverrideFeature.java

+2-13
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package com.lx862.svrutil.feature;
22

3-
import com.google.gson.JsonElement;
43
import com.google.gson.JsonObject;
54
import eu.pb4.placeholders.api.TextParserUtils;
65
import net.minecraft.text.Text;
6+
import net.minecraft.util.JsonHelper;
77

88
public class TextOverrideFeature extends Feature {
99
private static Text whitelistedMessage = null;
@@ -15,18 +15,7 @@ public TextOverrideFeature() {
1515
@Override
1616
public void readConfig(JsonObject jsonObject) {
1717
super.readConfig(jsonObject);
18-
if(jsonObject.has("whitelistedMessage")) {
19-
JsonElement element = jsonObject.get("whitelistedMessage");
20-
try {
21-
whitelistedMessage = Text.Serializer.fromJson(element);
22-
} catch (Exception ignored) {
23-
}
24-
25-
try {
26-
whitelistedMessage = TextParserUtils.formatText(element.getAsString());
27-
} catch (Exception ignored) {
28-
}
29-
}
18+
whitelistedMessage = JsonHelper.hasString(jsonObject, "whitelistedMessage") ? TextParserUtils.formatText(JsonHelper.getString(jsonObject, "whitelistedMessage")) : null;
3019
}
3120

3221
@Override

src/main/java/com/lx862/svrutil/feature/VanillaMechanicsFeature.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.lx862.svrutil.feature;
22

33
import com.google.gson.JsonObject;
4+
import net.minecraft.util.JsonHelper;
45

56
public class VanillaMechanicsFeature extends Feature {
67
private int fallingBlockDelay = 2;
@@ -14,9 +15,9 @@ public VanillaMechanicsFeature() {
1415
@Override
1516
public void readConfig(JsonObject jsonObject) {
1617
super.readConfig(jsonObject);
17-
this.fallingBlockDelay = jsonObject.get("fallingBlockDelay").getAsInt();
18-
this.immutableItemFrame = jsonObject.get("immutableItemFrame").getAsBoolean();
19-
this.minItemFrameInteractOpLevel = jsonObject.get("minItemFrameInteractOpLevel").getAsInt();
18+
this.fallingBlockDelay = JsonHelper.getInt(jsonObject, "fallingBlockDelay", fallingBlockDelay);
19+
this.immutableItemFrame = JsonHelper.getBoolean(jsonObject, "immutableItemFrame", immutableItemFrame);
20+
this.minItemFrameInteractOpLevel = JsonHelper.getInt(jsonObject, "minItemFrameInteractOpLevel", minItemFrameInteractOpLevel);
2021
}
2122

2223
@Override

src/main/resources/fabric.mod.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
],
2828

2929
"depends": {
30-
"fabricloader": ">=0.9",
30+
"fabricloader": ">=0.15",
3131
"fabric": "*",
3232
"minecraft": ">=1.19"
3333
}

0 commit comments

Comments
 (0)