Skip to content

Commit 80c5ba7

Browse files
authored
Upgrade pytorch-lightning to 1.5.9 (horovod#3480)
* Relax pytorch_lightning dependency to '>=1.3.8,<1.5.10' Signed-off-by: Enrico Minack <[email protected]>
1 parent 980ce05 commit 80c5ba7

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

docker-compose.test.yml

+8-9
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ services:
1212
TENSORFLOW_PACKAGE: tensorflow-cpu==2.8.0
1313
KERAS_PACKAGE: keras==2.8.0
1414
PYTORCH_PACKAGE: torch==1.11.0+cpu
15-
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.3.8
15+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
1616
TORCHVISION_PACKAGE: torchvision==0.12.0+cpu
1717
MXNET_PACKAGE: mxnet==1.9.0
1818
PYSPARK_PACKAGE: pyspark==3.2.1
@@ -65,7 +65,6 @@ services:
6565
TENSORFLOW_PACKAGE: tensorflow==1.15.5
6666
KERAS_PACKAGE: keras==2.2.4
6767
PYTORCH_PACKAGE: torch==1.8.1+cpu
68-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
6968
TORCHVISION_PACKAGE: torchvision==0.9.1+cpu
7069
MXNET_PACKAGE: mxnet==1.5.1.post0
7170
test-cpu-gloo-py3_8-tf2_6_3-keras2_6_0-torch1_9_1-mxnet1_7_0_p2-pyspark3_2_1:
@@ -95,7 +94,7 @@ services:
9594
KERAS_PACKAGE: None
9695
PYTORCH_PACKAGE: torch-nightly
9796
TORCHVISION_PACKAGE: torchvision
98-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
97+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
9998
MXNET_PACKAGE: mxnet-nightly
10099
# these are the lowest framework versions that Horovod compiles with, but they are not tested
101100
test-cpu-gloo-py3_7-tfmin-kerasmin-torchmin-mxnetmin-pysparkmin:
@@ -170,7 +169,7 @@ services:
170169
TENSORFLOW_PACKAGE: tensorflow-gpu==1.15.5
171170
KERAS_PACKAGE: keras==2.2.4
172171
PYTORCH_PACKAGE: torch==1.8.1+cu101
173-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
172+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
174173
TORCHVISION_PACKAGE: torchvision==0.9.1+cu101
175174
MXNET_PACKAGE: mxnet-cu100==1.5.1.post0
176175
# here we deviate from mxnet==1.7.0.post2 as there is none for cu101, only post1
@@ -185,7 +184,7 @@ services:
185184
TENSORFLOW_PACKAGE: tensorflow-gpu==2.6.3
186185
KERAS_PACKAGE: keras==2.6.0
187186
PYTORCH_PACKAGE: torch==1.9.1+cu102
188-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
187+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
189188
TORCHVISION_PACKAGE: torchvision==0.10.1+cu102
190189
MXNET_PACKAGE: mxnet-cu101==1.7.0.post1
191190
test-gpu-gloo-py3_8-tf2_7_1-keras2_7_0-torch1_10_2-mxnet1_8_0_p0-pyspark3_2_1:
@@ -198,7 +197,7 @@ services:
198197
TENSORFLOW_PACKAGE: tensorflow-gpu==2.7.1
199198
KERAS_PACKAGE: keras==2.7.0
200199
PYTORCH_PACKAGE: torch==1.10.2+cu111
201-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
200+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
202201
TORCHVISION_PACKAGE: torchvision==0.11.3+cu111
203202
MXNET_PACKAGE: mxnet-cu112==1.8.0.post0
204203
test-gpu-openmpi-gloo-py3_8-tf2_8_0-keras2_8_0-torch1_11_0-mxnet1_9_0-pyspark3_2_1:
@@ -212,7 +211,7 @@ services:
212211
TENSORFLOW_PACKAGE: tensorflow-gpu==2.8.0
213212
KERAS_PACKAGE: keras==2.8.0
214213
PYTORCH_PACKAGE: torch==1.11.0+cu113
215-
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.3.8
214+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
216215
TORCHVISION_PACKAGE: torchvision==0.12.0+cu113
217216
MXNET_PACKAGE: mxnet-cu112==1.9.0
218217
test-gpu-gloo-py3_8-tfhead-keras_none-torchhead-mxnethead-pyspark3_2_1:
@@ -225,7 +224,7 @@ services:
225224
TENSORFLOW_PACKAGE: tf-nightly-gpu
226225
KERAS_PACKAGE: None
227226
PYTORCH_PACKAGE: torch-nightly-cu111
228-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
227+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
229228
TORCHVISION_PACKAGE: torchvision
230229
MXNET_PACKAGE: mxnet-nightly-cu112
231230
# these are the lowest framework versions that Horovod compiles with, but they are not tested
@@ -257,7 +256,7 @@ services:
257256
TENSORFLOW_PACKAGE: tensorflow-gpu==2.8.0
258257
KERAS_PACKAGE: keras==2.8.0
259258
PYTORCH_PACKAGE: torch==1.11.0+cu113
260-
PYTORCH_LIGHTNING_PACKAGE: pytorch_lightning==1.3.8
259+
PYTORCH_LIGHTNING_PACKAGE: pytorch-lightning==1.5.9
261260
TORCHVISION_PACKAGE: torchvision==0.12.0+cu113
262261
MXNET_PACKAGE: mxnet-cu112==1.9.0
263262
HOROVOD_BUILD_FLAGS: ""

docker/horovod-cpu/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM ubuntu:20.04
33
# TensorFlow version is tightly coupled to CUDA and cuDNN so it should be selected carefully
44
ARG TENSORFLOW_VERSION=2.5.0
55
ARG PYTORCH_VERSION=1.8.1
6-
ARG PYTORCH_LIGHTNING_VERSION=1.2.9
6+
ARG PYTORCH_LIGHTNING_VERSION=1.5.9
77
ARG TORCHVISION_VERSION=0.9.1
88
ARG MXNET_VERSION=1.8.0.post0
99

docker/horovod-ray/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM rayproject/ray:${RAY_DOCKER_VERSION}-gpu
77
ARG RAY_DOCKER_VERSION=nightly
88
ARG TENSORFLOW_VERSION=2.5.0
99
ARG PYTORCH_VERSION=1.8.1+cu111
10-
ARG PYTORCH_LIGHTNING_VERSION=1.2.9
10+
ARG PYTORCH_LIGHTNING_VERSION=1.5.9
1111
ARG TORCHVISION_VERSION=0.9.1+cu111
1212

1313
# to avoid interaction with apt-get

docker/horovod/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ FROM nvidia/cuda:${CUDA_DOCKER_VERSION}
77
ARG CUDA_DOCKER_VERSION=11.2.2-devel-ubuntu18.04
88
ARG TENSORFLOW_VERSION=2.5.0
99
ARG PYTORCH_VERSION=1.8.1+cu111
10-
ARG PYTORCH_LIGHTNING_VERSION=1.2.9
10+
ARG PYTORCH_LIGHTNING_VERSION=1.5.9
1111
ARG TORCHVISION_VERSION=0.9.1+cu111
1212
ARG CUDNN_VERSION=8.1.1.33-1+cuda11.2
1313
ARG NCCL_VERSION=2.8.4-1+cuda11.2

setup.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def build_extensions(self):
162162
tensorflow_gpu_require_list = ['tensorflow-gpu']
163163
keras_require_list = ['keras>=2.0.8,!=2.0.9,!=2.1.0,!=2.1.1']
164164
# pytorch-lightning 1.3.8 is a stable version to work with horovod
165-
pytorch_require_list = ['torch', 'pytorch_lightning==1.3.8']
165+
pytorch_require_list = ['torch', 'pytorch_lightning>=1.3.8,<1.5.10']
166166
mxnet_require_list = ['mxnet>=1.4.1']
167167
pyspark_require_list = ['pyspark>=2.3.2;python_version<"3.8"',
168168
'pyspark>=3.0.0;python_version>="3.8"']
@@ -189,7 +189,7 @@ def build_extensions(self):
189189
'keras==2.3.1',
190190
'torch==1.4.0',
191191
'torchvision==0.5.0',
192-
'pytorch_lightning>=1.3.8',
192+
'pytorch_lightning>=1.3.8,<1.5.10',
193193
'mxnet==1.5.0',
194194
'pyspark==3.0.1'] + spark_require_list
195195
# torchvision 0.5.0 depends on torch==1.4.0

0 commit comments

Comments
 (0)