You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just ran into this as well, we rely on spirv.core.grammar.json quite extensively for our project to codegen quite a few things, and to be able to parse our inline-assembly SPIR-V. For that parsing we rely on the operands being correctly specified.
I see where the trouble with OpDecorate and OpMemberDecorate comes from - the operands can be of different types then just literals, however I would like to see this spec'd fully in the spirv.core.grammar.json even if that complicates the format somewhat.
+1 to this. I just noticed OpExecutionMode having this issue and created #211 to address it (and looking back, it seems that previously I had worked around Op*Decorate in codegen as well as OpImage* which has the same problem). Would be great to fix them in the grammar.
It seems some ops with a trailing list specified with "Literal, Literal, …" have this issue. Affected ops are:
OpDecorate
OpMemberDecorate
OpExecutionMode
OpLoopMerge
While these ops described with "Literal, Literal, …" are not affected:
OpVectorShuffle
OpCompositeExtract
OpCompositeInsert
OpBranchConditional
The text was updated successfully, but these errors were encountered: