Prepare chain upgrading#101
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jhelison
reviewed
Apr 29, 2025
| const amount = delegation?.balance?.amount || "0"; | ||
| const formattedAmount = (parseInt(amount) / 1000000).toLocaleString(); | ||
| const formattedAmount = ( | ||
| parseInt(amount) / 1000000000000000000 |
Collaborator
There was a problem hiding this comment.
We have this decimal converter in multiple place, this should be a constant and we should have a util convert function
| }; | ||
|
|
||
| const formatDenom = (denom: string) => (denom === "ukii" ? "kii" : denom); | ||
| const formatDenom = (denom: string) => (denom === "akii" ? "kii" : denom); |
Collaborator
There was a problem hiding this comment.
Centralized the denom into a constant
Comment on lines
+119
to
+120
| "https://rpc.plata-404.kiivalidator.com, | ||
| https://rpc.plata-404.kiivalidator.com" |
Collaborator
There was a problem hiding this comment.
Why the exposed links here (and not being a constant)? Also this should be testnet
| (acc: number, curr: DelegationResponse) => { | ||
| const amount = curr.balance?.amount | ||
| ? parseFloat(curr.balance.amount) / 1_000_000 | ||
| ? parseFloat(curr.balance.amount) / 1_000_000_000_000_000_000 |
Collaborator
There was a problem hiding this comment.
As the other comment, turn the number to convert into a constant and this conversion function into a util function
Comment on lines
+45
to
+49
| (r: Reward) => r.denom === "akii" | ||
| ); | ||
| const amount = kiiReward ? parseFloat(kiiReward.amount) / 1_000_000 : 0; | ||
| const amount = kiiReward | ||
| ? parseFloat(kiiReward.amount) / 1_000_000_000_000_000_000 | ||
| : 0; |
Collaborator
There was a problem hiding this comment.
Same thing here, constant and util function
Comment on lines
+5
to
+21
| // useHexToBech converts the evm address into the cosmos (Bech32) address | ||
| export function useHexToBech(evmAddress?: string) { | ||
| const cosmosAddress = useMemo(() => { | ||
| if (!evmAddress || !evmAddress.startsWith("0x") || !isAddress(evmAddress)) { | ||
| return null; | ||
| } | ||
|
|
||
| const bytes = Buffer.from(evmAddress.slice(2), "hex"); | ||
| if (bytes.length !== 20) { | ||
| return null; | ||
| } | ||
|
|
||
| return toBech32("kii", bytes); | ||
| }, [evmAddress]); | ||
|
|
||
| return { cosmosAddress }; | ||
| } |
Collaborator
There was a problem hiding this comment.
100% sure that this is generating the correct address right?
Comment on lines
+44
to
+66
| parseInt(stakingData.pool.bonded_tokens) / 1_000_000_000_000_000_000 | ||
| ).toFixed(2) | ||
| : "0.0"; | ||
|
|
||
| const communityPoolAmount = communityPoolData?.pool?.find( | ||
| (item: { denom: string }) => item.denom === "ukii" | ||
| (item: { denom: string }) => item.denom === "akii" | ||
| )?.amount; | ||
|
|
||
| const communityPoolKii = communityPoolAmount | ||
| ? (parseFloat(communityPoolAmount) / 1_000_000).toFixed(4) | ||
| : "0.0000"; | ||
| ? (parseFloat(communityPoolAmount) / 1_000_000_000_000_000_000).toFixed( | ||
| 1 | ||
| ) | ||
| : "0.0"; | ||
|
|
||
| const totalSupply = totalSupplyData?.supply?.find( | ||
| (item: { denom: string }) => item.denom === "akii" | ||
| ); | ||
|
|
||
| const totalSupplyKii = totalSupply | ||
| ? (parseFloat(totalSupply.amount) / 1_000_000_000_000_000_000).toFixed( | ||
| 1 | ||
| ) | ||
| : "0.0"; |
Collaborator
There was a problem hiding this comment.
Constant and util function
jhelison
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes make the following:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This code has been tested locally