Skip to content

feat: add governance and related events to custom modules#330

Merged
Thaleszh merged 6 commits into
mainfrom
feat/emit-events
Apr 14, 2026
Merged

feat: add governance and related events to custom modules#330
Thaleszh merged 6 commits into
mainfrom
feat/emit-events

Conversation

@Thaleszh
Copy link
Copy Markdown
Contributor

Description

  • Emit update_params, fund_pool, change_schedule, and reward_distributed events from x/rewards
  • Emit update_params and set_denom_metadata events from tokenfactory
  • Emit update_params, update_fee_tokens, module_disabled and token_disabled events on fee abstraction
  • Emit update_params event on oracle module

Type of change

  • New feature (non-breaking change which adds functionality)

PR Checklist:

Make sure each step was done:

  • Updated changelog with PR's intent
  • Lint with make lint-fix

@Thaleszh Thaleszh requested a review from jhelison as a code owner April 13, 2026 18:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 13, 2026

Warning

Rate limit exceeded

@Thaleszh has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10d6772c-b14c-40fa-8dbc-e84035abf486

📥 Commits

Reviewing files that changed from the base of the PR and between 6afcfe5 and 5a3855b.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • wasmbinding/tokenfactory/message_plugin.go

Walkthrough

This PR adds Cosmos SDK event emissions across multiple modules to track state transitions. Event type and attribute constants are introduced in respective types packages, with x/rewards/types/events.go being a new file. Event emissions are added to keeper methods throughout the codebase: UpdateParams operations emit update_params events; rewards operations emit fund_pool, change_schedule, and reward_distributed events; fee abstraction operations emit update_fee_tokens, module_disabled, and token_disabled events; and the token factory SetMetadata operation emits a set_denom_metadata event. The CHANGELOG documents these additions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'feat: add governance and related events to custom modules' accurately describes the main change: adding event emissions across multiple custom modules.
Description check ✅ Passed The pull request description is directly related to the changeset, providing a clear breakdown of which events are emitted from each module.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/emit-events

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Thaleszh
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Comment thread x/feeabstraction/keeper/oracle.go
Comment thread x/rewards/keeper/abci.go
@Thaleszh Thaleszh merged commit 388e065 into main Apr 14, 2026
10 of 11 checks passed
@Thaleszh Thaleszh deleted the feat/emit-events branch April 14, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants