fix: LagSpike, plugin not load fixed fully

Author: K4ryuu

src/Plugin/Plugin.cs

@@ -46,10 +46,7 @@ public void OnConfigParsed(PluginConfig config)
                 userId: databaseSettings.Username,
                 password: databaseSettings.Password,
                 port: databaseSettings.Port,
-                sslMode: databaseSettings.Sslmode,
-                usePooling: true,
-                minPoolSize: 2,
-                maxPoolSize: 2);
+                sslMode: databaseSettings.Sslmode);
 
             //** ? Save Config */
 
@@ -89,7 +86,6 @@ public override void Load(bool hotReload)
                 //** ? Load Player Caches */
 
                 LoadAllPlayersCache();
-                Database.Instance.AdjustDatabasePooling();
 
                 GameRules = Utilities.FindAllEntitiesByDesignerName<CCSGameRulesProxy>("cs_gamerules").First().GameRules;
             }

src/Plugin/PluginBasics.cs

@@ -160,7 +160,6 @@ public void Initialize_Events()
 			{
 				AddTimer(1.0f, () =>
 				{
-					Database.Instance.AdjustDatabasePooling();
 					GameRules = Utilities.FindAllEntitiesByDesignerName<CCSGameRulesProxy>("cs_gamerules").First().GameRules;
 				});
 			});

src/Plugin/PluginDatabase.cs

@@ -14,26 +14,12 @@ public sealed class Database
 
 		private Database() { }
 
-		public void Initialize(string server, string database, string userId, string password, int port = 3306, string sslMode = "None", bool usePooling = true, uint minPoolSize = 10, uint maxPoolSize = 50)
+		public void Initialize(string server, string database, string userId, string password, int port = 3306, string sslMode = "None")
 		{
-			connectionString = BuildConnectionString(server, database, userId, password, port, sslMode, usePooling, minPoolSize, maxPoolSize);
+			connectionString = BuildConnectionString(server, database, userId, password, port, sslMode);
 		}
 
-		public void AdjustDatabasePooling()
-		{
-			if (connectionString == null)
-				throw new InvalidOperationException("Database has not been initialized");
-
-			var builder = new MySqlConnectionStringBuilder(connectionString)
-			{
-				MinimumPoolSize = (uint)Math.Max(5, Server.MaxPlayers / 2.5),
-				MaximumPoolSize = (uint)Math.Max(10, Server.MaxPlayers + 1),
-			};
-
-			connectionString = builder.ConnectionString;
-		}
-
-		private static string BuildConnectionString(string server, string database, string userId, string password, int port, string sslMode, bool usePooling, uint minPoolSize, uint maxPoolSize)
+		private static string BuildConnectionString(string server, string database, string userId, string password, int port, string sslMode)
 		{
 			var builder = new MySqlConnectionStringBuilder
 			{
@@ -43,9 +29,6 @@ private static string BuildConnectionString(string server, string database, stri
 				Password = password,
 				Port = (uint)port,
 				SslMode = Enum.Parse<MySqlSslMode>(sslMode, true),
-				Pooling = usePooling,
-				MinimumPoolSize = 10,
-				MaximumPoolSize = 24,
 			};
 
 			return builder.ConnectionString;
@@ -79,12 +62,16 @@ public async Task ExecuteNonQueryAsync(string query, params MySqlParameter[] par
 
 		public async Task<MySqlDataReader> ExecuteReaderAsync(string query, params MySqlParameter[] parameters)
 		{
-			var connection = new MySqlConnection(connectionString);
-			await connection.OpenAsync();
+			using (var connection = new MySqlConnection(connectionString))
+			{
+				await connection.OpenAsync();
 
-			var command = new MySqlCommand(query, connection);
-			command.Parameters.AddRange(parameters);
-			return await command.ExecuteReaderAsync(CommandBehavior.CloseConnection);
+				using (var command = new MySqlCommand(query, connection))
+				{
+					command.Parameters.AddRange(parameters);
+					return await command.ExecuteReaderAsync(CommandBehavior.CloseConnection);
+				}
+			}
 		}
 
 		public async Task ExecuteWithTransactionAsync(Func<MySqlConnection, MySqlTransaction, Task> executeActions)