Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OXT dimmer module does not expose switch_type and generally is unstable #24788

Closed
mikolajpiecuch opened this issue Nov 15, 2024 · 14 comments
Closed
Labels
problem Something isn't working stale Stale issues

Comments

@mikolajpiecuch
Copy link

What happened?

Firstly, I came back to z2m after almost 2 years. Two years ago I added to the z2m my OXT dimmer, then it was added as a TS110E. I added even then an issue -> 16520. Back in the time, as I remember, it worked great. Unfortunately, now (2 years it was unconnected) I can't see for sure "switch_type" option and generally dimmer works very unstable - wall switch even has a problem with turning off/on this module, same problem from z2m UI.

My dimmer module is made by OXT. I see some devices here OXT (despite fact z2m adds this device as TS110E), there is no OXT dimmer. There is wrong picture/name in the "TS0001_switch_module" - in the title (and description) it's called switch but in the picture we can dimmer module (very similar to mine)

What did you expect to happen?

My device is recognized and works properly

How to reproduce it (minimal and precise)

No response

Zigbee2MQTT version

1.41.0

Adapter firmware version

20210708

Adapter

Sonoff Zigbee 3.0

Setup

Add-On on Home Assistant OS on proxmox

Debug log

No response

@mikolajpiecuch mikolajpiecuch added the problem Something isn't working label Nov 15, 2024
@wpak18
Copy link

wpak18 commented Nov 16, 2024

I got the same problem on OXT 2 channel dimmer, no switch_type option and is recognized as:

`const {deviceEndpoints, light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
zigbeeModel: ['TS110E'],
model: 'TS110E',
vendor: '_TZ3210_3mpwqzuu',
description: 'Automatically generated definition',
extend: [deviceEndpoints({"endpoints":{"1":1,"2":2}}), light(), light()],
meta: {"multiEndpoint":true},
};

module.exports = definition;`

{ "brightness_l1": 219, "brightness_l2": 207, "light_type": "led", "linkquality": 208, "max_brightness": 255, "max_brightness_l1": 255, "max_brightness_l2": 255, "min_brightness": 1, "min_brightness_l1": 1, "min_brightness_l2": 1, "power_on_behavior": "off", "power_on_behavior_l1": "off", "power_on_behavior_l2": "previous", "state_l1": "OFF", "state_l2": "OFF" }

@mikolajpiecuch
Copy link
Author

mikolajpiecuch commented Nov 16, 2024

I found this commit removed switch type for _TZ3210_k1msuvg6 -> Koenkk/zigbee-herdsman-converters@401d1c4#diff-0157bb612c63e92c50f93116e1f50bf8e263030ed26d86caa28479159c2a9f4aR8052
I prepared Koenkk/zigbee-herdsman-converters#8326 but I'm not sure if not affects other devices

@wpak18
Copy link

wpak18 commented Nov 19, 2024

Stil dont have option switch_type for TS110E_2gang_2 OXT dimmer

@FPSUsername
Copy link

This is quite problematic, I just installed this dimmer only to find out a core feature has been removed.
My vendor shows as _TZ3210_3mpwqzuu

@mikolajpiecuch
Copy link
Author

mikolajpiecuch commented Nov 25, 2024

@wpak18 / @FPSUsername sorry, I completely forgot to add switch type also for 2 channel dimmer. Ready to merge but I don't have this device to check if it works correctly. I did this based on others devices. Are you able to check this on your side? Koenkk/zigbee-herdsman-converters#8379
EDIT: @Koenkk already merged it :)

Btw, do you guys have a problem with correct state reporting? I observe strange behaviour with my dimmer - few minutes after turning off it shows again as turned on. I haven't debug it yet, but do you observe sth similar?

@FPSUsername
Copy link

FPSUsername commented Nov 25, 2024

I just got the dimmer, so I have to figure out how it all works. I believe that I did see one false report where it showed that one of the two lights were reported as off, while it was on.

I run home assistant via the docker image (so I can make use of HACS and such) and use a Sonoff zigbee dongle.

Currently trying to figure out how to get this updated repository, I could use a helping hand.

Thanks for the ultra quick merge.
By the way, does this device support OTA (and does it have any updates?). I don't know what firmware it currently has.

@mikolajpiecuch
Copy link
Author

mikolajpiecuch commented Nov 25, 2024

@FPSUsername to test only my changes you can add this two lines https://github.com/Koenkk/zigbee-herdsman-converters/pull/8379/files in your tuya.js file. I use HAOS but it should be similar in your case. Here is a simple instruction (for HAOS addon but you can see general rule to test changes) https://github.com/zigbee2mqtt/hassio-zigbee2mqtt?tab=readme-ov-file#testing-changes-locally

@FPSUsername
Copy link

FPSUsername commented Nov 25, 2024

I'm trying to edit node_modules/zigbee-herdsman-converters/devices/tuya.js but the whole TS110E entry doesn't seem to exist. I copied the whole block, lets see.

I am running the latest version:
Zigbee2MQTT
Current version: 1.41.0-1

@FPSUsername
Copy link

Thank you, amazing work on the quick resolution!

It now works!

@FPSUsername
Copy link

FPSUsername commented Nov 26, 2024

@mikolajpiecuch I too seem to have incorrect reporting of the on/off state.

The lights are turned off, updated in HA, but after a while one of them shows as turned on (even though the lights and the switches are off)

The same happens when the lights are turned on, after a while HA shows that one of the lights is turned off when nothing changed.

@iroger
Copy link

iroger commented Nov 27, 2024

Not sure if it is related but next to state being reported wrongly after a while I also have the issue with scenes. Turning off is no issue but turning on HA appears to send only the new dim value and the lamp doesn't turn on. (It is on in HA dashboard) after switching off-on the new dimmed value is visible. If the device is already on switching scene immediately shows the new dimmed value.

I actually switched my entire network from ZHA to Z2M because of this issue... 🤦🏼‍♂️

@iroger
Copy link

iroger commented Nov 28, 2024

It looks like the wrong state reporting is somehow linked to the power on behavior, a fix was posted on another forum which seems to change the behavior:

  1. turn off all the lights in home assistant
  2. switch of the mains, wait 10s, turn on mains again
  3. after limited testing it seems stable now

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale issues label Jan 28, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2025
@FPSUsername
Copy link

It looks like the wrong state reporting is somehow linked to the power on behavior, a fix was posted on another forum which seems to change the behavior:

  1. turn off all the lights in home assistant
  2. switch of the mains, wait 10s, turn on mains again
  3. after limited testing it seems stable now

So I think I found out how to trigger the ghosting "light is off" for L1 after a while. If you put the power on behavior to off, then the light report will remain on until you actually turn off the lights. For some reason, L1 is reported incorrectly in the off state when the power on behavior is set to previous. Oddly enough it doesn't happen for L2, but there's another but because it's not configurable: #26759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working stale Stale issues
Projects
None yet
Development

No branches or pull requests

4 participants