Skip to content

Commit 37e2e8a

Browse files
committed
Correctly calculate endpage
Change-Id: I8d0c07da122c282fda5e9361b8b8c26d22a75d1c
1 parent a102c34 commit 37e2e8a

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

Changes

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- [bugfix] Prevent showing empty elements and opening tags past primary data
66
(diewald).
77
- [cleanup] Cleanup test generated directories after run (diewald)
8+
- [bugfix] Correctly calculate endpage (diewald)
89

910
0.62.6 2024-06-13
1011
- [feature] Make match expansion configurable (close #150, margaretha)

src/main/java/de/ids_mannheim/korap/response/Match.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1106,7 +1106,7 @@ public List<int[]> retrieveMarkers (LeafReaderContext atomic,
11061106
if (pagebreaks.get(i)[0] <= this.getStartPos()) {
11071107
this.startPage = pagebreaks.get(i)[1];
11081108
} else {
1109-
i++;
1109+
// i++;
11101110
break;
11111111
};
11121112
};

src/test/java/de/ids_mannheim/korap/index/TestPagebreakIndex.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,16 @@ public void testPageBreakDocLowerThanLocalDocId () throws IOException {
8282
kr.getMatch(2).getSnippetHTML());
8383
assertEquals("{%528}abcab[[{%529}c]]ab{%530}ac",
8484
kr.getMatch(2).getSnippetBrackets());
85-
assertEquals(-1, kr.getMatch(2).getEndPage()); // Debatable
85+
assertEquals(-1, kr.getMatch(2).getEndPage());
8686

8787
assertEquals(9, kr.getMatch(3).getStartPos());
8888
assertEquals(10, kr.getMatch(3).getEndPos());
8989
assertEquals(530, kr.getMatch(3).getStartPage());
9090
assertEquals(-1, kr.getMatch(3).getEndPage());
91+
assertEquals("<span class=\"context-left\"><span class=\"more\"></span>ab<span class=\"pb\" data-after=\"529\"></span>cab<span class=\"pb\" data-after=\"530\"></span>a</span><span class=\"match\"><mark>c</mark></span><span class=\"context-right\"></span>",
92+
kr.getMatch(3).getSnippetHTML());
93+
assertEquals("... ab{%529}cab{%530}a[[c]]",
94+
kr.getMatch(3).getSnippetBrackets());
9195
};
9296

9397
@Test
@@ -147,7 +151,7 @@ public void indexExample1 () throws Exception {
147151
kr = ki.search(sq, (short) 10);
148152

149153
assertEquals(528, kr.getMatch(0).getStartPage());
150-
assertEquals(-1, kr.getMatch(0).getEndPage());
154+
assertEquals(529, kr.getMatch(0).getEndPage());
151155

152156
assertEquals(
153157
"snippetHTML",

0 commit comments

Comments
 (0)