-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kotlin version to 1.9.22 #181
Conversation
@@ -21,6 +21,9 @@ kotlin { | |||
testRuns["test"].executionTask.configure { | |||
useJUnit() | |||
} | |||
attributes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like functionalTests
always use the same Kotlin version as the projects, so after updating to 1.9.22 we need to declare build variants here. Otherwise, the configuration won't succeed.
@@ -13,7 +13,7 @@ import org.intellij.lang.annotations.Language | |||
public val API_DIR: String = ApiValidationExtension().apiDumpDirectory | |||
|
|||
internal fun BaseKotlinGradleTest.test( | |||
gradleVersion: String = "7.4.2", | |||
gradleVersion: String = "8.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we change the minimal supported Gradle version for BCV?
If so, worth noting it in README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll double check it. But here the version was updated only to make tests work with 1.9.22 (as I mentioned elsewhere, that version leaks into functional tests and I don't know what to do with that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we ever mentioned it explicitly, but the minimum supported Gradle version is 6.0 and after updating to Kotlin 1.9.22 the plugin still works with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As part of KLib support (#149) we need to bump the Kotlin version as the required API is only available starting from the 1.9.20.