Skip to content

Commit 7be2575

Browse files
committed
Removed types = ["TABLE"] argument from readAllSqlTables
In other databases like DuckDB, this type is actually "BASE TABLE" instead of "TABLE", making the function return 0 results. Setting it to `null` makes the integration do its default behavior, which usually is no filtering at all.
1 parent 14c4176 commit 7be2575

File tree

1 file changed

+1
-1
lines changed
  • dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io

1 file changed

+1
-1
lines changed

dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ public fun DataFrame.Companion.readAllSqlTables(
643643
val determinedDbType = dbType ?: extractDBTypeFromConnection(connection)
644644

645645
// exclude a system and other tables without data, but it looks like it is supported badly for many databases
646-
val tables = metaData.getTables(catalogue, null, null, arrayOf("TABLE"))
646+
val tables = metaData.getTables(catalogue, null, null, null)
647647

648648
val dataFrames = mutableMapOf<String, AnyFrame>()
649649

0 commit comments

Comments
 (0)