Add documentation for functions and classes in PlotConv2D.kt #381
Replies: 6 comments
-
There is no public API here. Agree it requires refactoring for the given examples. |
Beta Was this translation helpful? Give feedback.
-
Everything in the file is visible from the outside. If this was not intended, then the visibility should be |
Beta Was this translation helpful? Give feedback.
-
It was a bunch of helper classes for a few examples. Probably it could became a public API, but it's not at this moment. I'm not sure about making internal, if examples will work, why not, but for me is enough that it has no public modifiers |
Beta Was this translation helpful? Give feedback.
-
Let's move them to the Currently the whole file is highlighted yellow because of the missing documentation. We should either move the file, change visibility or add documentation. |
Beta Was this translation helpful? Give feedback.
-
I found that I used visualisation during the demos, so it could be a helper class It's strange that the whole file is highlighted yellow because where is no
in the gradle in this module. We requires doc only for public methods in libraries, right? And in this case we doesn't require it yet. |
Beta Was this translation helpful? Give feedback.
-
@juliabeliaeva I converted it to the discussion, let's discuss the proposal about the future of visualization module here. |
Beta Was this translation helpful? Give feedback.
-
See PlotConv2D.kt
Beta Was this translation helpful? Give feedback.
All reactions