You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is to improve the usefulness of the hover view by associating stats on the trade result items with stats on the price checked item. There will likely not be much for ui changes with this task. The general summary is to create a more built out DisplayItem where the stats on that item are properly linked to the stats on the user's item they are trying to check
Currently this has just enough information on it so that TooltipItem can display somewhat useful information to the user. The goal is to have some object, DisplayItem or some extension of it, that has enough data on it so that it may be consumed by a few different tooltip/comparison widgets. The current one will remain, but the intent is to have a few different options for whatever the user may want to see, currently thinking a POE2 one using poe-item-display, a "comparison" one showing the stats next to the ones on the price check filters, and keeping current as legacy support.
Note:
Currently this has a massive problem when the user has their interface set to a different language than the server they are searching trade results on. This is not able to be done for english, but any language other than english has the option to query the english trade site. This will return the english results regardless of the users UI language. There is currently no implemented way to query/parse info of a different language than the selected one. This will only be accepted if it doesn't fail/break when the user's language doesn't match trade site's language. It is fine right now if it doesn't work for wrong languages rn but it shouldn't crash the program or break the UI significantly.
The text was updated successfully, but these errors were encountered:
This is to improve the usefulness of the hover view by associating stats on the trade result items with stats on the price checked item. There will likely not be much for ui changes with this task. The general summary is to create a more built out
DisplayItem
where the stats on that item are properly linked to the stats on the user's item they are trying to checkExiled-Exchange-2/renderer/src/web/price-check/trade/pathofexile-trade.ts
Lines 263 to 270 in 75d96fb
Currently this has just enough information on it so that TooltipItem can display somewhat useful information to the user. The goal is to have some object,
DisplayItem
or some extension of it, that has enough data on it so that it may be consumed by a few different tooltip/comparison widgets. The current one will remain, but the intent is to have a few different options for whatever the user may want to see, currently thinking a POE2 one using poe-item-display, a "comparison" one showing the stats next to the ones on the price check filters, and keeping current as legacy support.Note:
Currently this has a massive problem when the user has their interface set to a different language than the server they are searching trade results on. This is not able to be done for english, but any language other than english has the option to query the english trade site. This will return the english results regardless of the users UI language. There is currently no implemented way to query/parse info of a different language than the selected one. This will only be accepted if it doesn't fail/break when the user's language doesn't match trade site's language. It is fine right now if it doesn't work for wrong languages rn but it shouldn't crash the program or break the UI significantly.
The text was updated successfully, but these errors were encountered: