Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listings hover view #377

Open
Kvan7 opened this issue Jan 25, 2025 · 0 comments
Open

Update listings hover view #377

Kvan7 opened this issue Jan 25, 2025 · 0 comments
Labels
enhancement New feature or request task [Dev only] just needs to get done

Comments

@Kvan7
Copy link
Owner

Kvan7 commented Jan 25, 2025

This is to improve the usefulness of the hover view by associating stats on the trade result items with stats on the price checked item. There will likely not be much for ui changes with this task. The general summary is to create a more built out DisplayItem where the stats on that item are properly linked to the stats on the user's item they are trying to check

export interface DisplayItem {
runeMods?: string[];
implicitMods?: string[];
explicitMods?: string[];
enchantMods?: string[];
pseudoMods?: string[];
extended?: Array<{ text: string; value: number }>;
}

Currently this has just enough information on it so that TooltipItem can display somewhat useful information to the user. The goal is to have some object, DisplayItem or some extension of it, that has enough data on it so that it may be consumed by a few different tooltip/comparison widgets. The current one will remain, but the intent is to have a few different options for whatever the user may want to see, currently thinking a POE2 one using poe-item-display, a "comparison" one showing the stats next to the ones on the price check filters, and keeping current as legacy support.

Note:

Currently this has a massive problem when the user has their interface set to a different language than the server they are searching trade results on. This is not able to be done for english, but any language other than english has the option to query the english trade site. This will return the english results regardless of the users UI language. There is currently no implemented way to query/parse info of a different language than the selected one. This will only be accepted if it doesn't fail/break when the user's language doesn't match trade site's language. It is fine right now if it doesn't work for wrong languages rn but it shouldn't crash the program or break the UI significantly.

@Kvan7 Kvan7 added enhancement New feature or request task [Dev only] just needs to get done labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task [Dev only] just needs to get done
Projects
None yet
Development

No branches or pull requests

1 participant