Ogg playback differs between LMMS versions

[tresf]

This issue was originally reported in #dev-casual on Discord.

• drums/crash01.ogg
  • Most versions of LMMS load this file as 923 ms
  • Some versions of LMMS load this file as 1311 ms

Some baselines:

• ffprobe drums/crash.ogg shows 1311 ms
• Audacity on macOS shows 1311 ms
• Audacity on Windows shows 923 ms
• LMMS on macOS shows 923 ms

According to this article, the files are most likely at fault, quoting:

[length of OGG Vorbis is] an issue with your file. Also, I've reproduced the issue in VLC [...]

If this is true, this should be a way to detect faulty files:

find ~/lmms/data -type f -name "*.ogg" -print0 | xargs -0 -I {} bash -c 'oggz validate "{}" >/dev/null 2>&1 || echo "Validation failed for: {}"' |sort

Notice crash01.ogg appears here:

Validation failed for: ~/lmms/data/samples/drums/bassdrum01.ogg
Validation failed for: ~/lmms/data/samples/drums/bassdrum04.ogg
Validation failed for: ~/lmms/data/samples/drums/clap01.ogg
Validation failed for: ~/lmms/data/samples/drums/crash01.ogg
Validation failed for: ~/lmms/data/samples/drums/hihat_opened02.ogg
Validation failed for: ~/lmms/data/samples/drums/kick_hardcore01.ogg
Validation failed for: ~/lmms/data/samples/drums/shaker01.ogg
Validation failed for: ~/lmms/data/samples/drums/snare01.ogg
Validation failed for: ~/lmms/data/samples/instruments/cello01.ogg
Validation failed for: ~/lmms/data/samples/instruments/e_organ01.ogg
Validation failed for: ~/lmms/data/samples/misc/applause01.ogg

We need to find a way to render these .ogg files as they've HISTORICALLY sounded like (e.g. using Audacity on Windows) so that projects don't change sound as a result of a library update.

Tagging @StakeoutPunch @Monospace-V.

[Monospace-V]

I find a discrepancy between the ffprobe listed length and the Audacity-shown length for three of the listed files. Assuming Audacity behaves the way LMMS does for the ogg files, these files seem to have issue:

/drums/crash01.ogg
/instruments/cello01.ogg
/instruments/e-organ01.ogg

e-organ01 sounds like a vehicle horn, so it may not necessarily seem to need fixing upon first sight, but the length of the file could cause compatibility issues.