-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
AFP UI: Hide loopback point and knob when loop mode disabled #7819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've spoken about this on Discord, so I'll be brief. There's a reason the "no loop" option is the largest one. That's enough indication to me that we're not looping anything. It also looks kind of odd with that gaping hole, and the UI nicely uses arrows, so moving them around would look weird (meaning ⬅️, ➡️, ➡️⬅️ would look weird as opposed to ⬅️, ➡️⬅️, ➡️). Also, we're treating the user like they're incompetent to notice the loop option set on the sample. The more stuff we hide, the less the user looks at it, and the less it sticks in his memory. I dunno, I don't want to make too big of a deal of such a small feature, but I don't think this should be made, simply because of the UI and UX issues. |
The fact we use the same sort of buttons for loop options (radio toggle) as we do for sample playback mode (checkbox) is also something we might want to change in the future. This is a cause for concern: two similar-looking types of button sets shouldn't behave differently. |
I like it but I agree with @bratpeki the gap does look off. |
Could we grey it out? |
Enhancement Summary
When loop mode is set to disabled, hide loopback knob and loopback marker.
Currently our AudioFileProcessor shows loopback point knob and loop marker and highlight even when loop mode is disabled. See:
Implementation Details / Mockup
Please search the issue tracker for existing feature requests before submitting your own.
The text was updated successfully, but these errors were encountered: