Opening Organ_leslie.xpf in OpulenZ factory presets shows a warning that makes it difficult to load the file

[musicguy423]

System Information

Windows 11

LMMS Version(s)

1.3.0-alpha.1.815+1721534

Most Recent Working Version

No response

Bug Summary

When I load Organ_leslie.xpf in OpulenZ factory presets, I get a warning that says: "The project contains 1 LADSPA plugin(s) which might not have been restored correctly! Please check the project."

It prevents me from dragging and dropping it to the rack. I still can right-click it and click "send to active instrument-track", but I still find it annoying to deal with.

Expected Behaviour

It didn't need to give me that warning window which prevents me from dragging and dropping it

Steps To Reproduce

Go to My presets
Go to OpulenZ folder
Click Organ_leslie.xpf

Logs

Click to expand

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[michaelgregorius]

This issue is related to #5738.

FYI, @JohannesLorenz. The preset contains a "Calf Rotary Speaker" LADSPA plugin which has the ports as attributes:

lmms/data/presets/OpulenZ/Organ_leslie.xpf

Lines 19 to 25 in 1721534

	<effect autoquit_numerator="4" autoquit_denominator="4" syncmode="0" autoquit="1" gate="0" name="ladspaeffect" wet="1" on="1">
	<ladspacontrols port04="2" port05="0.5" port06="0.5" port07="0.5" port08="28.025" port09="28.025" ports="10" port010="0.75" port011="0.25" port012="0.5" port013="0"/>
	<key>
	<attribute value="calf" name="file"/>
	<attribute value="RotarySpeaker" name="plugin"/>
	</key>
	</effect>

All in all there are three problematic presets left (search done in the presets folder):

$ grep -ril "port[0-9]*="
LB302/STrash.xpf
OpulenZ/Organ_leslie.xpf
TripleOscillator/E-Organ2.xpf

I guess it might be good to fix the presets as @bratpeki has offered to do in this comment: #5738 (comment).

There's still the need to fix this in code as well because save files with problematic effects need to be fixed in code.

[Monospace-V]

I guess it might be good to fix the presets as bratpeki has offered to do in this comment: #5738 (comment).

There's still the need to fix this in code as well because save files with problematic effects need to be fixed in code.

This issue also exists in other project files that have the effects (eg, Thaledric Armageddon). Have also brought this up on the discord. Some of these files are compressed, so it may be necessary to check each file (or dump all demo files to mmp so they can easily be searched for issues while checking for backward compatibility in the future).
It looks to be the exact same issue as the one you linked.
If you are downloading others' files, you aren't unlikely to come across a file giving this issue: it will crop up very often in some user cases.