-
Notifications
You must be signed in to change notification settings - Fork 167
New sources mznovels, shanghaifantasy, katreadingarchive[lightnovelwp] #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- can now determine author (hopefully most of the time) - can get chapter release dates - (imo) better detection of content boundaries - footnotes & author's comment added - custom CSS
- generator now supports custom runtime JS and CSS, property names changed to clarify the difference - fixed some type errors - attempt to make "hide locked" option work
plugins/english/relibrary.ts
Outdated
| // edge cases like this. | ||
| content.find('p:has(>code)+code:has(+p:has(>code))').each((_i, el) => { | ||
| if ( | ||
| el.attribs.style.match(/(.*;)?font-family: 'Merriweather', serif;.*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/(.*?;)?font-family: 'Merriweather', serif.*/
| ?.join('\n') || '' | ||
| ); | ||
| const content = $('div.epcontent'); | ||
| // content.find('h1:first-child').remove(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably remove those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I don't is because I don't actually know if this is always the title. Maybe it's up to the author to put an h1 there manually, and it could be literally any text then, even story-relevant. Unless someone can confirm that this title is a general feature of all pages based on lightnovelwp, I'd rather move this to the customTransformJs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked another lightnovelwp source in the meantime, and while the title does seem to be autogenerated on katreadingarchive (assumedly), it isn't on other sites. So this definitely goes in the customTransformJS.
I also found a bug in the chapter number discovery: it breaks for locked chapters, which has kept annoying me in the update tab.
|
I should've started this on a separate branch, but oh well |
…in a separate file
the reason I did was that `serve:dev` is broken now because of the restructuring. This needs more care in the future.
|
#1867 fixes the issue I had with the last commit btw |
& improvements to relibrary & lightnovelwp template