Update cache dependency paths in CI workflow#212
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
hey @mubking, thanks for trying to fix the CI cache issue!
heads up though — changing cache-dependency-path from package-lock.json to package.json is actually the wrong fix here. the cache: 'npm' option in actions/setup-node is specifically designed to look at the lock file to determine when the cache should be invalidated. pointing it at package.json means the cache won't bust when your actual dependency tree changes, which can cause stale cache issues.
the correct fix is to make sure the lock files exist at the right paths:
frontend/package-lock.jsonbackend/package-lock.json
if those files are missing, run npm install in each folder to generate them and commit them. then revert the cache-dependency-path lines back to pointing at the lock files.
also — i noticed you have four open PRs (#212, #213, #214, #215) that all attempt the same CI fix. please close the older ones and just keep the latest single PR once you have the correct fix. having multiple open PRs for the same thing makes it hard to track.
this PR also has merge conflicts — once you've made the fix above, rebase on main to clear those.
happy to help if you're stuck — jump in on Telegram: https://t.me/+DOylgFv1jyJlNzM0
|
closing this PR — it's been open since March without activity and has failing CI from a stale base. the codebase has moved on significantly since this was opened. if the changes here are still relevant, please open a fresh PR against current main. join us on Telegram if you want to coordinate: https://t.me/+DOylgFv1jyJlNzM0 |
Description
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes