Update PHP Versions Used In Package Requirements and For Testing Against #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2021-01-07 PHP only supports versions 7.4, 8.0 and 8.1 - https://www.php.net/supported-versions.php so we should only be testing against these versions.
The required version(s) of PHP have been updated so we're only used supported PHP versions (https://www.php.net/supported-versions.php). As of today that is 7.4, 8.0 and 8.1.
Contributor
Author
|
These are failing due to PHPUnit 7.5 not working with PHP 8.0 and 8.1. This should be safe to merge @Laizerox. I will create a new PR to get PHPUnit updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates our
composer.jsonfile so we now require versions of PHP which are supported by PHP themselves. This also updates the GitHub Actions workflow file so we're testing against those same supported versions.